Status check should fail if "conditional" step fails#22948
Merged
stianst merged 1 commit intokeycloak:mainfrom Sep 5, 2023
Merged
Status check should fail if "conditional" step fails#22948stianst merged 1 commit intokeycloak:mainfrom
stianst merged 1 commit intokeycloak:mainfrom
Conversation
Passing run #8801 ↗︎Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
ghost
reviewed
Sep 4, 2023
ghost
left a comment
There was a problem hiding this comment.
Unreported flaky test detected, please review
Unreported flaky test detectedIf the below flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR. org.keycloak.testsuite.x509.X509BrowserLoginTest#loginWithRevalidateCertEnabledCertIsTrustedKeycloak CI - Java Distribution IT (windows-latest - temurin - 19) |
Member
Author
|
@stianst - please have a look at this PR as you've been involved in these workflows. Once it is approved, it should IMHO be applied to the KC22 branch as well. |
stianst
approved these changes
Sep 5, 2023
stianst
pushed a commit
to stianst/keycloak
that referenced
this pull request
Sep 5, 2023
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #22947