Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@ahus1
Copy link
Member

@ahus1 ahus1 commented Sep 5, 2023

Closes #22932

Backport of #22945

(cherry picked from commit 71fa957)

Closes keycloak#22932

(cherry picked from commit 71fa957)
@ahus1 ahus1 self-assigned this Sep 5, 2023
@ahus1
Copy link
Member Author

ahus1 commented Sep 5, 2023

@mhajas - the builds are still running, please review when you have the time. Thanks!

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@ghost
Copy link

ghost commented Sep 5, 2023

Unreported flaky test detected

If the below flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.model.user.UserSyncTest#testManyUsersImport

Keycloak CI - Store Model Tests

org.keycloak.models.ModelException: org.keycloak.models.ModelException: Error creating subcontext [uid=user1,ou=People,dc=keycloak,dc=org]
	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
	at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:499)
...

Report flaky test

@ahus1 ahus1 marked this pull request as ready for review September 5, 2023 10:39
@ahus1 ahus1 requested a review from a team as a code owner September 5, 2023 10:39
Copy link
Contributor

@mhajas mhajas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ahus1

@mhajas mhajas merged commit c494c60 into keycloak:release/22.0 Sep 5, 2023
@stianst stianst mentioned this pull request Sep 11, 2023
@ahus1 ahus1 deleted the is-22932-backport branch September 21, 2023 16:59
@stianst stianst mentioned this pull request Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants