-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Run store testing conditionally for PRs #22070
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b0b3253 to
e6e485a
Compare
|
Hi @stianst - thank for looking into this. The model tests cover both the old and the new store, so the flag So suggest: Either rename |
Was half thinking to run all store testing conditionally. What do you think about that? I can rename to ci-store regardless I'd say? |
|
@stianst - running |
e6e485a to
a386828
Compare
Yup, this only applies for pull requests events, everything run for all other events |
2 flaky tests on run #8297 ↗︎Details:
|
|||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Authentication test > should add a condition |
Output
Screenshots
|
|
realm_settings_events_test.spec.ts • 1 flaky test • chrome
| Test | Artifacts | |
|---|---|---|
| Realm settings events tab tests > Should remove event from event listener |
Output
Screenshots
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
ahus1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you for these changes!
No description provided.