Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@stianst
Copy link
Contributor

@stianst stianst commented Jul 28, 2023

No description provided.

@stianst stianst requested a review from a team as a code owner July 28, 2023 10:29
jonkoops
jonkoops previously approved these changes Jul 28, 2023
@stianst stianst force-pushed the new-store-conditional branch 2 times, most recently from b0b3253 to e6e485a Compare July 28, 2023 10:32
@stianst stianst requested a review from a team July 28, 2023 10:42
@ghost ghost added the team/store label Jul 28, 2023
@ahus1
Copy link
Contributor

ahus1 commented Jul 28, 2023

Hi @stianst - thank for looking into this. The model tests cover both the old and the new store, so the flag ci-new-store to run the model tests is IMHO misleading.

So suggest: Either rename ci-new-store to ci-store, or remove the condition store-model-tests

@stianst
Copy link
Contributor Author

stianst commented Jul 28, 2023

Hi @stianst - thank for looking into this. The model tests cover both the old and the new store, so the flag ci-new-store to run the model tests is IMHO misleading.

So suggest: Either rename ci-new-store to ci-store, or remove the condition store-model-tests

Was half thinking to run all store testing conditionally. What do you think about that?

I can rename to ci-store regardless I'd say?

@ahus1
Copy link
Contributor

ahus1 commented Jul 28, 2023

@stianst - running legacy-store-integration-tests on that condition would work for me as well. I assume the tests will run in the main CI on schedule still.

@stianst stianst force-pushed the new-store-conditional branch from e6e485a to a386828 Compare July 28, 2023 11:20
@stianst stianst changed the title Run new store testing conditionally for PRs Run store testing conditionally for PRs Jul 28, 2023
@stianst
Copy link
Contributor Author

stianst commented Jul 28, 2023

@stianst - running legacy-store-integration-tests on that condition would work for me as well. I assume the tests will run in the main CI on schedule still.

Yup, this only applies for pull requests events, everything run for all other events

@cypress
Copy link

cypress bot commented Jul 28, 2023

2 flaky tests on run #8297 ↗︎

0 527 48 0 Flakiness 2

Details:

Merge 41eb58b into 6c38ba4...
Project: Keycloak Admin UI Commit: b7f401af9f ℹ️
Status: Passed Duration: 17:18 💡
Started: Jul 28, 2023 1:43 PM Ended: Jul 28, 2023 2:00 PM
Flakiness  authentication_test.spec.ts • 1 flaky test • chrome

View Output Video

Test Artifacts
Authentication test > should add a condition Output Screenshots
Flakiness  realm_settings_events_test.spec.ts • 1 flaky test • chrome

View Output Video

Test Artifacts
Realm settings events tab tests > Should remove event from event listener Output Screenshots

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

Copy link
Contributor

@ahus1 ahus1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for these changes!

@ahus1 ahus1 merged commit c907fde into keycloak:main Jul 31, 2023
stianst added a commit to stianst/keycloak that referenced this pull request Sep 4, 2023
stianst added a commit that referenced this pull request Sep 4, 2023
This was referenced Sep 6, 2023
@stianst stianst mentioned this pull request Nov 14, 2023
@stianst stianst deleted the new-store-conditional branch July 17, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants