Fixed creating user #23484
Fixed creating user #23484
Conversation
jonkoops
left a comment
There was a problem hiding this comment.
Looks like this PR fixes several bugs, if they are two distinct bugs I would prefer we have two PRs instead. The reason for this is that we can only link a single issue per commit, otherwise one of them will not show up in the release notes.
| import { toUser } from "./routes/User"; | ||
|
|
||
| import "./user-section.css"; | ||
| import RealmRepresentation from "libs/keycloak-admin-client/lib/defs/realmRepresentation"; |
There was a problem hiding this comment.
This import should be coming from @keycloak/keycloak-admin-client
| await adminClient.users.update( | ||
| { id: user!.id! }, | ||
| toUserRepresentation(data), | ||
| { |
There was a problem hiding this comment.
The toUserRepresentation() function still needs to be called on the data being passed here.
Passing run #9058 ↗︎Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
2 flaky tests on run #9064 ↗︎Details:
|
|||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Group test > Child Groups > Delete group from item bar |
Output
Screenshots
|
|
masthead_test.spec.ts • 1 flaky test • firefox
| Test | Artifacts | |
|---|---|---|
| Masthead tests > Desktop view > Go to account console and back to admin console |
Output
Screenshots
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
Closes #23327