operator: Replace dead documentation link #23777
Conversation
8971e40 to
c81df08
Compare
c81df08 to
9eefd8d
Compare
|
Rebased. |
Before this patch, the documentation link generated for the Operator page resulted in a 404 Not Found on Github pages. With this change, the documentation link points to the "Operator" anchor in the Keycloak docs index. Note that the operator docs don't seem to be versioned on the Keycloak website.
|
Rebased. |
9eefd8d to
5ced8e0
Compare
|
hmm, maybe I should ping someone. @jonkoops? |
jonkoops
left a comment
There was a problem hiding this comment.
I am not a maintainer so I cannot merge this, but changes look good to me.
|
@vmuzikar Is there anything else expected from me, before this PR can be merged? |
|
@pierreprinetti Please do not @ other team members, we're already pretty busy and this just adds more notifications for us. Your PR will be picked up when the maintainers have time to do so. |
|
Side-bar. Could you perhaps log an issue for this fix? This is something we might want to backport to the existing release, and we need an issue to track that. |
vmuzikar
left a comment
There was a problem hiding this comment.
@pierreprinetti Thanks for the PR!
Change LGTM but we need the GH Issue as mentioned by @jonkoops. Please see https://github.com/keycloak/keycloak/blob/main/CONTRIBUTING.md
|
@vmuzikar issue us now linked, can you take another look? |
Before this patch, the documentation link generated for the Operator page resulted in a 404 Not Found on Github pages. With this change, the documentation link points to the "Operator" anchor in the Keycloak docs index. Note that the operator docs don't seem to be versioned on the Keycloak website.
Before this patch, the documentation link generated for the Operator page resulted in a 404 Not Found on Github pages. With this change, the documentation link points to the "Operator" anchor in the Keycloak docs index. Note that the operator docs don't seem to be versioned on the Keycloak website.
Before this patch, the documentation link generated for the Operator page resulted in a 404 Not Found on Github pages.
With this change, the documentation link points to the "Operator" anchor in the Keycloak docs index. Note that the operator docs don't seem to be versioned on the Keycloak website.
Fixes #24143