Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@ssilvert
Copy link
Contributor

Fixes #23294

@ssilvert ssilvert requested a review from a team as a code owner October 13, 2023 18:37
@ghost ghost added the team/ui label Oct 13, 2023
@cypress
Copy link

cypress bot commented Oct 13, 2023

2 flaky tests on run #9444 ↗︎

0 527 48 0 Flakiness 2

Details:

Merge 79a8f26 into c51060a...
Project: Keycloak Admin UI Commit: f0c3a87cfd ℹ️
Status: Passed Duration: 11:33 💡
Started: Oct 17, 2023 11:06 AM Ended: Oct 17, 2023 11:18 AM
Flakiness  clients_test.spec.ts • 1 flaky test • chrome

View Output Video

Test Artifacts
Clients test > Accessibility tests for clients > Check a11y violations on load/ clients list tab Test Replay Output Screenshots
Flakiness  realm_settings_general_tab_test.spec.ts • 1 flaky test • chrome

View Output Video

Test Artifacts
Realm settings general tab tests > Test all general tab switches Test Replay Output Screenshots

Review all test suite changes for PR #23983 ↗︎

Copy link
Contributor

@jonkoops jonkoops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonkoops jonkoops force-pushed the issue-23294-fga-authorization-tab branch from 51ecc0b to 1a5e224 Compare October 13, 2023 23:48
@ssilvert ssilvert force-pushed the issue-23294-fga-authorization-tab branch from 1a5e224 to 302358e Compare October 15, 2023 20:13
@ssilvert ssilvert force-pushed the issue-23294-fga-authorization-tab branch from 302358e to 79a8f26 Compare October 17, 2023 10:56
@ssilvert ssilvert merged commit dfe64f6 into keycloak:main Oct 17, 2023
jonkoops pushed a commit to jonkoops/keycloak that referenced this pull request Oct 18, 2023
…ion (keycloak#23983)

* Allow full use of Authorization tab for anyone with manage-authorization
access.

* Allow export with manage-authorization role.

* manage-authorization makes more sense for the subtabs
@stianst stianst mentioned this pull request Nov 14, 2023
@ssilvert ssilvert deleted the issue-23294-fga-authorization-tab branch January 10, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

admin-fine-grained-authz + client authorization settings requires more realm-management roles

2 participants