Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Disable CockroachDB model tests since they are flaky #23391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mhajas merged 1 commit into from
Sep 20, 2023
Merged

Disable CockroachDB model tests since they are flaky #23391

mhajas merged 1 commit into from
Sep 20, 2023

Conversation

@mhajas
Copy link
Contributor

@mhajas mhajas commented Sep 20, 2023

Closes #22645

@mhajas mhajas requested a review from a team September 20, 2023 13:15
@mhajas mhajas requested a review from a team as a code owner September 20, 2023 13:15
@ghost ghost added team/store labels Sep 20, 2023
@ghost ghost added the flaky-test label Sep 20, 2023
This was referenced Sep 20, 2023
Closed
Closed
Closed
ghost
ghost reviewed Sep 20, 2023
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@ghost
Copy link

ghost commented Sep 20, 2023

Unreported flaky test detected

If the below flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.ui.account2.WelcomeScreenTest#personalInfoTest

Keycloak CI - Account Console IT (firefox)

org.awaitility.core.ConditionTimeoutException: Assertion condition defined as a org.keycloak.testsuite.util.URLAssert URL expected to begin with: https://localhost:8543/auth/realms/test/protocol/openid-connect/auth ; actual URL: https://localhost:8543/auth/realms/test/account/#/personal-info within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:985)
...

Report flaky test

@mhajas mhajas enabled auto-merge (squash) September 20, 2023 15:19
@mhajas mhajas merged commit 533f9e7 into keycloak:main Sep 20, 2023
@mhajas mhajas deleted the 22645-Flaky-test-org-keycloak-testsuite-model-ConcurrentHashMapStorageTest-testStorageSeparation branch September 20, 2023 16:04
ghost
ghost reviewed Sep 20, 2023
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@ghost
Copy link

ghost commented Sep 20, 2023

Unreported flaky test detected

If the below flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.ui.account2.WelcomeScreenTest#personalInfoTest

Keycloak CI - Account Console IT (firefox)

org.awaitility.core.ConditionTimeoutException: Assertion condition defined as a org.keycloak.testsuite.util.URLAssert URL expected to begin with: https://localhost:8543/auth/realms/test/protocol/openid-connect/auth ; actual URL: https://localhost:8543/auth/realms/test/account/#/personal-info within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:985)
...

Report flaky test

mhajas added a commit to mhajas/keycloak that referenced this pull request Sep 21, 2023
@mhajas
Disable CockroachDB model tests since they are flaky (keycloak#23391)
1168f8d 
Closes keycloak#22645

Signed-off-by: Michal Hajas <[email protected]>
(cherry picked from commit 533f9e7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahus1 ahus1 ahus1 approved these changes

+1 more reviewer
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

flaky-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Flaky test: org.keycloak.testsuite.model.ConcurrentHashMapStorageTest#testStorageSeparation

2 participants

@mhajas @ahus1