Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Align wildfly-core and wildfly version for tests#23395

Merged
ahus1 merged 1 commit intokeycloak:mainfrom
rmartinc:issue-23342
Sep 21, 2023
Merged

Align wildfly-core and wildfly version for tests#23395
ahus1 merged 1 commit intokeycloak:mainfrom
rmartinc:issue-23342

Conversation

@rmartinc
Copy link
Contributor

@rmartinc rmartinc commented Sep 20, 2023

Setting wildfly-core aligned with the version of wildfly tested. The recent upgrade of version to 21 broke the app-server-wildfly adapter tests. Going back to 19 for the tests.

Closes #23342

@rmartinc rmartinc requested review from a team as code owners September 20, 2023 16:12
@rmartinc rmartinc requested a review from a team September 20, 2023 16:12
@rmartinc rmartinc requested a review from a team as a code owner September 20, 2023 16:12
This was referenced Sep 20, 2023
Closed
Closed
Closed
Closed
@ghost
Copy link

ghost commented Sep 20, 2023

Unreported flaky test detected

If the below flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.ui.account2.WelcomeScreenTest#applicationsTest

Keycloak CI - Account Console IT (firefox)

org.awaitility.core.ConditionTimeoutException: Assertion condition defined as a org.keycloak.testsuite.util.URLAssert URL expected to begin with: https://localhost:8543/auth/realms/test/protocol/openid-connect/auth ; actual URL: https://localhost:8543/auth/realms/test/account/#/applications within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:985)
...

Report flaky test

ghost
ghost reviewed Sep 20, 2023
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

miquelsi
miquelsi approved these changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@miquelsi miquelsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are passing successfully now. Thanks @rmartinc!

ahus1
ahus1 approved these changes Sep 21, 2023
View reviewed changes
Copy link
Member

@ahus1 ahus1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as of @miquelsi's review.

@ahus1 ahus1 merged commit 7afd909 into keycloak:main Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahus1 ahus1 ahus1 approved these changes

+2 more reviewers

@miquelsi miquelsi miquelsi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

flaky-test team/cloud-native

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Test failures with Wildfly/EAP adapters using TLS

3 participants

@rmartinc @miquelsi @ahus1