Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix IllegalState InjectionManagerFactory not found on springboot tests #24254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ahus1 merged 1 commit into from
Oct 31, 2023
Merged

Fix IllegalState InjectionManagerFactory not found on springboot tests #24254

ahus1 merged 1 commit into from
Oct 31, 2023

Conversation

@Aboullos
Copy link
Contributor

@Aboullos Aboullos commented Oct 24, 2023

Fixes #24061

@Aboullos Aboullos requested review from a team as code owners October 24, 2023 14:47
@Aboullos Aboullos requested a review from a team October 24, 2023 14:47
@Aboullos Aboullos requested a review from a team as a code owner October 24, 2023 14:47
@ghost ghost added the flaky-test label Oct 24, 2023
@ghost ghost mentioned this pull request Oct 24, 2023
Closed
@ghost ghost mentioned this pull request Oct 24, 2023
Closed
@Aboullos Aboullos force-pushed the springboot-test branch 2 times, most recently from 11ef009 to ec34dc1 Compare October 26, 2023 07:26
@ghost ghost mentioned this pull request Oct 26, 2023
Closed
@ghost ghost mentioned this pull request Oct 27, 2023
Closed
@abstractj abstractj requested a review from mhajas October 30, 2023 17:09
@ahus1
Copy link
Contributor

ahus1 commented Oct 31, 2023

Merging as of @miquelsi's review. For a future iteration, I'd like to avoid a pause in the tests, but instead wait for a UI element to appear: Pauses usually lead to brittle tests, and it is unclear what they are waiting for if it is blunt pause like in this example.

@ahus1 ahus1 merged commit c23e1e0 into keycloak:main Oct 31, 2023
@mabartos mabartos mentioned this pull request Oct 31, 2023
Merged
Aboullos added a commit to Aboullos/keycloak that referenced this pull request Nov 2, 2023
@Aboullos @mhajas
Fix springboot tests (keycloak#24254)
70e1750 
Co-authored-by: Michal Hajas <[email protected]>
stianst pushed a commit that referenced this pull request Nov 2, 2023
@Aboullos @mhajas
Fix springboot tests (#24254) (#24423)
3ad633a 
Co-authored-by: Michal Hajas <[email protected]>
@stianst stianst mentioned this pull request Nov 14, 2023
Closed
@stianst stianst mentioned this pull request May 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abstractj abstractj abstractj approved these changes

@mhajas mhajas Awaiting requested review from mhajas

+1 more reviewer

@miquelsi miquelsi miquelsi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

flaky-test team/cloud-native

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Adapter tests failing

5 participants

@Aboullos @ahus1 @abstractj @miquelsi @mhajas