Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Map Store Removal: Remove protostream dependency #25869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ahus1 merged 1 commit into from
Jan 3, 2024
Merged

Map Store Removal: Remove protostream dependency #25869

ahus1 merged 1 commit into from
Jan 3, 2024

Conversation

@martin-kanis
Copy link
Contributor

@martin-kanis martin-kanis commented Jan 3, 2024

Closes #25288

@martin-kanis martin-kanis requested a review from a team as a code owner January 3, 2024 08:59
@ghost ghost added the flaky-test label Jan 3, 2024
@ghost ghost mentioned this pull request Jan 3, 2024
Closed
sguilhen
sguilhen suggested changes Jan 3, 2024
View reviewed changes
Copy link
Contributor

@sguilhen sguilhen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@martin-kanis I found a reference to protostream in https://github.com/keycloak/keycloak/blob/main/distribution/api-docs-dist/pom.xml#L67-L71

@martin-kanis martin-kanis force-pushed the 25288-remove-protostream branch from 1e09289 to d4bccf8 Compare January 3, 2024 13:51
@martin-kanis
Copy link
Contributor Author

martin-kanis commented Jan 3, 2024

@martin-kanis I found a reference to protostream in https://github.com/keycloak/keycloak/blob/main/distribution/api-docs-dist/pom.xml#L67-L71

Thanks @sguilhen. I removed that one.

ahus1
ahus1 approved these changes Jan 3, 2024
View reviewed changes
Copy link
Contributor

@ahus1 ahus1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as of @sguilhen's review

@ahus1 ahus1 enabled auto-merge (rebase) January 3, 2024 13:59
@ahus1 ahus1 merged commit 022e809 into keycloak:main Jan 3, 2024
ghost
ghost reviewed Jan 3, 2024
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@ghost
Copy link

ghost commented Jan 3, 2024

Unreported flaky test detected

If the below flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.ui.account2.DeleteAccountTest#deleteOwnAccountForbiddenWithoutClientRole

Keycloak CI - Account Console IT (chrome)

org.openqa.selenium.NoSuchElementException: 
no such element: Unable to locate element: {"method":"css selector","selector":"#username"}
  (Session info: chrome-headless-shell=120.0.6099.109)
For documentation on this error, please visit: http://seleniumhq.org/exceptions/no_such_element.html
Build info: version: '3.14.0', revision: 'aacccce0', time: '2018-08-02T20:19:58.91Z'
...

Report flaky test

org.keycloak.testsuite.ui.account2.WelcomeScreenTest#accountSecurityTest

Keycloak CI - Account Console IT (chrome)

org.openqa.selenium.NoSuchElementException: 
no such element: Unable to locate element: {"method":"css selector","selector":"#username"}
  (Session info: chrome-headless-shell=120.0.6099.109)
For documentation on this error, please visit: http://seleniumhq.org/exceptions/no_such_element.html
Build info: version: '3.14.0', revision: 'aacccce0', time: '2018-08-02T20:19:58.91Z'
...

Report flaky test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahus1 ahus1 ahus1 approved these changes

+2 more reviewers

@sguilhen sguilhen sguilhen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

flaky-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Map Store Removal: Remove protostream dependency

3 participants

@martin-kanis @sguilhen @ahus1