Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add Multi-AZ Aurora DB to CI store-integration-tests#26970

Merged
ahus1 merged 1 commit intokeycloak:mainfrom
ryanemerson:aurora_functional_tests_ec2
Feb 14, 2024
Merged

Add Multi-AZ Aurora DB to CI store-integration-tests#26970
ahus1 merged 1 commit intokeycloak:mainfrom
ryanemerson:aurora_functional_tests_ec2

Conversation

@ryanemerson
Copy link
Contributor

@ryanemerson ryanemerson commented Feb 12, 2024

@cypress
Copy link

cypress bot commented Feb 12, 2024

Passing run #11029 ↗︎

0 556 53 0 Flakiness 0

Details:

Merge 82581cb into f7a594a...
Project: Keycloak Admin UI Commit: e1a11e0aca ℹ️
Status: Passed Duration: 08:05 💡
Started: Feb 14, 2024 12:44 PM Ended: Feb 14, 2024 12:53 PM

Review all test suite changes for PR #26970 ↗︎

Copy link
Member

@ahus1 ahus1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR, I'm happy to see a first green run in a reasonable amount of time!

One overall comment: It seems to me CLUSTER_NAME is set to keycloak_$(whoami). IMHO this would lead to conflicts if two workflows would run in parallel, for example when they try to create a SSH key which is then already present. I remember from previous attempts that the playbook will then not write the key to disk, and due to that the next ssh command will fail.

So AFAIK we'll need a an identifier which is unique to the run. Maybe we can use an (abbreviated?) GitHub commit ID for this.

See below for some comments on specific code snippets.

@ryanemerson ryanemerson force-pushed the aurora_functional_tests_ec2 branch 4 times, most recently from ad23e2b to c4b5d3e Compare February 13, 2024 15:55
@ryanemerson ryanemerson force-pushed the aurora_functional_tests_ec2 branch from 48eb24f to 82581cb Compare February 14, 2024 12:37
@ryanemerson
Copy link
Contributor Author

Successful run of the Aurora tests on my fork https://github.com/ryanemerson/keycloak/actions/runs/7901290946/job/21564969343

@ahus1 ahus1 self-requested a review February 14, 2024 15:45
Copy link
Member

@ahus1 ahus1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ryanemerson - thank you for this PR which is a huge step towards our goal!

It is good to get it merged now, and we'll get more feedback by doing this.

When reviewing this, two things should be fixed ASAP once this has been merged:

  • Maven is run without the batch flag -B which creates a lot more output than needed.
  • The Aurora tasks should be skipped if now AWS token is available to avoid errors on forked repositories. Otherwise it would annoy fellow team members.

I've added this to issue #26967

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Multi-AZ Aurora DB to CI store-integration-tests

3 participants