-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Remove Account Console version 2 #27510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
38f3392 to
8e18889
Compare
b1af160 to
28ac71c
Compare
4130daa to
479dab4
Compare
Closes keycloak#19664 Signed-off-by: Jon Koops <[email protected]>
edewit
approved these changes
Mar 27, 2024
agagancarczyk
approved these changes
Mar 27, 2024
Contributor
agagancarczyk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
ahus1
approved these changes
Mar 27, 2024
Contributor
ahus1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, and approving also based on previous approvals. Not merging it yet in case additional UI team members want to review it.
hmlnarik
added a commit
to hmlnarik/keycloak
that referenced
this pull request
Apr 17, 2024
Follows-up: keycloak#27510 Signed-off-by: Hynek Mlnarik <[email protected]>
hmlnarik
added a commit
to hmlnarik/keycloak
that referenced
this pull request
Jul 11, 2024
Follows-up: keycloak#27510 Signed-off-by: Hynek Mlnarik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the source code for the Account Console version 2 and fixes up any code that still relied on this feature. This PR does not include release notes, or removal of now dead testing code, which will be handled in a separate PR.
Closes #19664