Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add new ProviderConfigProperty type to expose URLs in admin-v2 #27743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jonkoops merged 2 commits into from
May 14, 2024
Merged

Add new ProviderConfigProperty type to expose URLs in admin-v2 #27743

jonkoops merged 2 commits into from
May 14, 2024

Conversation

@nicolabeghin
Copy link
Contributor

@nicolabeghin nicolabeghin commented Mar 9, 2024 •
edited by jonkoops
Loading

Closes #27673

Approach 2 (wider)

Given after admin-v2 migration custom IdPs can already leverage ConfiguredProvider to show new fields, it's possible to extend this structure with a new type Url to be used to show any given URL, therefore adding any number of read-only URLs in the admin UI.

Example output from custom SAML IdP configured with

    return ProviderConfigurationBuilder.create()
    .property()
    .name(METADATA_URL)
    .type(ProviderConfigProperty.URL_TYPE)
    .defaultValue("/realms/<realm>/example-metadata-url")
    .label("identity-provider.saml.url.metadata")
    .helpText("identity-provider.saml.url.metadata.tooltip")
    .add()
image

@nicolabeghin nicolabeghin requested review from a team as code owners March 9, 2024 09:39
@nicolabeghin nicolabeghin mentioned this pull request Mar 9, 2024
Closed
@nicolabeghin
Copy link
Contributor Author

nicolabeghin commented Mar 9, 2024

@jonkoops I think it's now complete and ready for review! It's my first contribution to such a big project so please be lenient 😅

hmlnarik
hmlnarik reviewed Mar 11, 2024
View reviewed changes
Copy link
Contributor

@hmlnarik hmlnarik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR. Please see inline

@jonkoops jonkoops changed the title Add new ProviderConfigProperty type to expose URLs in admin-v2 (keycloak/keycloak#27673) Add new ProviderConfigProperty type to expose URLs in admin-v2 Mar 11, 2024
@nicolabeghin
Copy link
Contributor Author

nicolabeghin commented Mar 13, 2024

Just to be sure: all requested changes should have been taken care of!

@nicolabeghin
Copy link
Contributor Author

nicolabeghin commented Mar 18, 2024

@hmlnarik @edewit anything else to take into account to get this merged? I'm available if required! thanks

edewit
edewit suggested changes Mar 25, 2024
View reviewed changes
edewit
edewit previously approved these changes Mar 28, 2024
View reviewed changes
@edewit edewit enabled auto-merge (squash) March 28, 2024 12:28
jonkoops
jonkoops suggested changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@jonkoops jonkoops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there are some code formatting issues, can you run the linter and fix them? It should be possible to do this automatically using pnpm --filter admin-ui lint -- --fix.

@jonkoops
Copy link
Contributor

jonkoops commented Mar 28, 2024

Sorry for the late review by the way, I was stuck on some other tasks for a while.

auto-merge was automatically disabled March 28, 2024 17:16

Head branch was pushed to by a user without write access

@nicolabeghin
Copy link
Contributor Author

nicolabeghin commented Mar 28, 2024

Looks like there are some code formatting issues, can you run the linter and fix them? It should be possible to do this automatically using pnpm --filter admin-ui lint -- --fix.

Done! and thanks for taking the time to review

@edewit edewit requested a review from jonkoops April 2, 2024 08:40
jonkoops
jonkoops suggested changes Apr 2, 2024
View reviewed changes
@jonkoops
Copy link
Contributor

jonkoops commented Apr 2, 2024

@nicolabeghin took another look, and I agree we likely cannot get around this styling. This looks good to me, but we have to merge the PatternFly 5 upgrade first (see #28196).

@jonkoops jonkoops added the status/hold PR should not be merged. On hold for later. label Apr 2, 2024
edewit
edewit previously approved these changes Apr 9, 2024
View reviewed changes
@edewit edewit enabled auto-merge (squash) April 9, 2024 12:31
@jonkoops jonkoops disabled auto-merge April 9, 2024 15:00
jonkoops
jonkoops suggested changes Apr 9, 2024
View reviewed changes
jonkoops
jonkoops previously approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@jonkoops jonkoops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some nits

@jonkoops jonkoops requested review from edewit and hmlnarik May 14, 2024 08:48
jonkoops
jonkoops suggested changes May 14, 2024
View reviewed changes
@jonkoops
Copy link
Contributor

jonkoops commented May 14, 2024

@nicolabeghin for future reference, when pulling in from main try to use the rebase strategy rather than merge, as it keeps the commit history cleaner.

@nicolabeghin nicolabeghin requested a review from jonkoops May 14, 2024 08:59
@jonkoops jonkoops removed the status/hold PR should not be merged. On hold for later. label May 14, 2024
@jonkoops jonkoops enabled auto-merge (squash) May 14, 2024 09:15
@jonkoops
Copy link
Contributor

jonkoops commented May 14, 2024

Thanks for your contribution and patience @nicolabeghin! I've set the PR to merge automatically once the CI completes.

hmlnarik
hmlnarik approved these changes May 14, 2024
View reviewed changes
Copy link
Contributor

@hmlnarik hmlnarik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@jonkoops jonkoops merged commit 3d1c20b into keycloak:main May 14, 2024
@nicolabeghin nicolabeghin deleted the keycloak-expose-custom-idp-saml-endpoint-v2 branch May 14, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@edewit edewit edewit approved these changes

@jonkoops jonkoops jonkoops approved these changes

@hmlnarik hmlnarik hmlnarik approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@edewit edewit

@hmlnarik hmlnarik

Labels

team/ui

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Hardcoded SAML metadata URL in admin-v2

4 participants

@nicolabeghin @jonkoops @edewit @hmlnarik