Do not challenge inside spnego authenticator is FORKED_FLOW #27803
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes keycloak#20637 Signed-off-by: rmartinc <[email protected]>
mposolda
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20637
The spengo authenticator skips sending the challenge when the FORKED_FLOW is detected in the session. There are other ways of avoiding the challenge (for example using some flag only for spnego) but as I saw that FORKED_FLOW is only used by
reset-credentialsflow, so I think it's OK. Just let me know if you think it's better doing something more specific. Adding a little test to see the reser credentials works with no kerberos re-authentication.