Restrict access to whoami endpoint for the admin console and users with realm access #28930
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th realm access Closes keycloak#25219 Signed-off-by: rmartinc <[email protected]>
Unreported flaky test detectedIf the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR. org.keycloak.testsuite.account.AccountRestServiceTest#updateConsentForClientWithPutKeycloak CI - Java Distribution IT (windows-latest - temurin - 19) org.keycloak.testsuite.account.AccountRestServiceTest#createConsentForClientWithPutKeycloak CI - Java Distribution IT (windows-latest - temurin - 19) org.keycloak.testsuite.account.AccountRestServiceTest#createConsentForClientKeycloak CI - Java Distribution IT (windows-latest - temurin - 19) |
This was referenced May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #25219
This PR modifies the
whoamiendpoint to return forbidden/403 in two situations: theazporissuedForis notsecurity-admin-console(we are ensuring this endpoint is just used for the admin console); the user mapped to the token has no pemissions/access to the requested realm (previously it returned a response with empty realm access). This is what was decided when the issue #25219 was discussed inside the team.Besides the test
AdminConsolePermissionsCalculatedTestwas removed because it makes no sense since thewhoamiendpoint was changed to just return the access for one realm (#21553). I have added some tests in the classAdminConsoleWhoAmILocaleTest. Maybe we can rename that class because now it's testing more than just the locale part, but I finally didn't do it. If you prefer to call itAdminConsoleWhoAmITestor similar just let me know.