Remove deprecated ConfigSourceInterceptor method #28055
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Martin Bartoš <[email protected]>
shawkins
reviewed
Mar 21, 2024
Contributor
shawkins
left a comment
There was a problem hiding this comment.
It would be safer for now to throw an unsupported exception from the deprecated method.
Pepo48
approved these changes
Mar 21, 2024
Pepo48
approved these changes
Mar 21, 2024
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #28125
The
io.smallrye.config.ConfigSourceInterceptor#iterateValuesis marked as deprecated and for removal, so we should get rid of it.Also mentioned here: #25333 (comment)
@shawkins Could you please take a look at this small PR as you were the author? Thanks