DefaultBruteForceProtector leverages a single thread to write success /failed events #28368

douglaspalmer · 2024-04-02T14:44:15Z

mposolda · 2024-04-05T05:38:47Z

@rmartinc Could you please review this PR?

keycloak-github-bot

Unreported flaky test detected, please review

keycloak-github-bot · 2024-04-10T17:15:55Z

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.organization.admin.OrganizationTest#testAttributes

Keycloak CI - Store IT (mariadb)

java.lang.AssertionError: expected:<[val11, val12]> but was:<[val12, val11]>
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.failNotEquals(Assert.java:835)
	at org.junit.Assert.assertEquals(Assert.java:120)
	at org.junit.Assert.assertEquals(Assert.java:146)
...

Report flaky test

org.keycloak.testsuite.organization.admin.OrganizationTest#testAttributes

Keycloak CI - Store IT (mssql)

java.lang.AssertionError: expected:<[val11, val12]> but was:<[val12, val11]>
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.failNotEquals(Assert.java:835)
	at org.junit.Assert.assertEquals(Assert.java:120)
	at org.junit.Assert.assertEquals(Assert.java:146)
...

java.lang.AssertionError: expected:<[val11, val12]> but was:<[val12, val11]>
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.failNotEquals(Assert.java:835)
	at org.junit.Assert.assertEquals(Assert.java:120)
	at org.junit.Assert.assertEquals(Assert.java:146)
...

Report flaky test

keycloak-github-bot

Unreported flaky test detected, please review

keycloak-github-bot · 2024-04-11T02:03:39Z

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.organization.admin.OrganizationTest#testAttributes

Keycloak CI - Store IT (mssql)

java.lang.AssertionError: expected:<[val11, val12]> but was:<[val12, val11]>
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.failNotEquals(Assert.java:835)
	at org.junit.Assert.assertEquals(Assert.java:120)
	at org.junit.Assert.assertEquals(Assert.java:146)
...

Report flaky test

org.keycloak.testsuite.organization.admin.OrganizationTest#testAttributes

Keycloak CI - Store IT (mysql)

java.lang.AssertionError: expected:<[val21, val22]> but was:<[val22, val21]>
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.failNotEquals(Assert.java:835)
	at org.junit.Assert.assertEquals(Assert.java:120)
	at org.junit.Assert.assertEquals(Assert.java:146)
...

Report flaky test

mposolda

@douglaspalmer @rmartinc Agree that this version looks much simpler. Thanks for the update!

Added one comment inline.

services/src/main/java/org/keycloak/services/managers/DefaultBruteForceProtector.java

keycloak-github-bot

Unreported flaky test detected, please review

keycloak-github-bot · 2024-04-11T07:59:01Z

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.organization.admin.OrganizationTest#testAttributes

Keycloak CI - Store IT (mssql)

java.lang.AssertionError: expected:<[val11, val12]> but was:<[val12, val11]>
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.failNotEquals(Assert.java:835)
	at org.junit.Assert.assertEquals(Assert.java:120)
	at org.junit.Assert.assertEquals(Assert.java:146)
...

Report flaky test

org.keycloak.testsuite.organization.admin.OrganizationTest#testAttributes

Keycloak CI - Store IT (mysql)

java.lang.AssertionError: expected:<[val21, val22]> but was:<[val22, val21]>
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.failNotEquals(Assert.java:835)
	at org.junit.Assert.assertEquals(Assert.java:120)
	at org.junit.Assert.assertEquals(Assert.java:146)
...

Report flaky test

rmartinc

Thanks @douglaspalmer! Just a minor comment.

...ispan/src/main/java/org/keycloak/models/sessions/infinispan/entities/LoginFailureEntity.java

…/failed events Closes keycloak#14084 Signed-off-by: Douglas Palmer <[email protected]>

keycloak-github-bot · 2024-04-11T17:26:50Z

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.admin.IdentityProviderTest#testSamlImportWithAnyEncryptionMethod

Keycloak CI - Base IT (1)

java.lang.AssertionError: identityProviders instance count expected:<1> but was:<2>
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.failNotEquals(Assert.java:835)
	at org.junit.Assert.assertEquals(Assert.java:647)
	at org.keycloak.testsuite.admin.IdentityProviderTest.testSamlImport(IdentityProviderTest.java:761)
...

Report flaky test

org.keycloak.testsuite.admin.IdentityProviderTest#testSamlImportWithAnyEncryptionMethod

Keycloak CI - Store IT (mariadb)

java.lang.AssertionError: identityProviders instance count expected:<1> but was:<2>
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.failNotEquals(Assert.java:835)
	at org.junit.Assert.assertEquals(Assert.java:647)
	at org.keycloak.testsuite.admin.IdentityProviderTest.testSamlImport(IdentityProviderTest.java:761)
...

Report flaky test

org.keycloak.testsuite.admin.IdentityProviderTest#testSamlImportWithAnyEncryptionMethod

Keycloak CI - Store IT (mssql)

java.lang.AssertionError: identityProviders instance count expected:<1> but was:<2>
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.failNotEquals(Assert.java:835)
	at org.junit.Assert.assertEquals(Assert.java:647)
	at org.keycloak.testsuite.admin.IdentityProviderTest.testSamlImport(IdentityProviderTest.java:761)
...

Report flaky test

org.keycloak.testsuite.admin.IdentityProviderTest#testSamlImportWithAnyEncryptionMethod

Keycloak CI - Store IT (mysql)

java.lang.AssertionError: identityProviders instance count expected:<1> but was:<2>
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.failNotEquals(Assert.java:835)
	at org.junit.Assert.assertEquals(Assert.java:647)
	at org.keycloak.testsuite.admin.IdentityProviderTest.testSamlImport(IdentityProviderTest.java:761)
...

Report flaky test

org.keycloak.testsuite.admin.IdentityProviderTest#testSamlImportWithAnyEncryptionMethod

Keycloak CI - Store IT (oracle)

java.lang.AssertionError: identityProviders instance count expected:<1> but was:<2>
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.failNotEquals(Assert.java:835)
	at org.junit.Assert.assertEquals(Assert.java:647)
	at org.keycloak.testsuite.admin.IdentityProviderTest.testSamlImport(IdentityProviderTest.java:761)
...

Report flaky test

org.keycloak.testsuite.admin.IdentityProviderTest#testSamlImportWithAnyEncryptionMethod

Keycloak CI - Store IT (postgres)

java.lang.AssertionError: identityProviders instance count expected:<1> but was:<2>
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.failNotEquals(Assert.java:835)
	at org.junit.Assert.assertEquals(Assert.java:647)
	at org.keycloak.testsuite.admin.IdentityProviderTest.testSamlImport(IdentityProviderTest.java:761)
...

Report flaky test

keycloak-github-bot

Unreported flaky test detected, please review

rmartinc

Thanks @douglaspalmer! Approving. I did a comment because there is a comment which I think it's outdated but it's a minor thing.

rmartinc · 2024-04-12T07:30:48Z

services/src/main/java/org/keycloak/services/managers/DefaultBruteForceProtector.java

+        // wait a minimum of seconds for type to process so that a hacker
+        // cannot flood with failed logins and overwhelm the queue and not have notBefore updated to block next requests
+        // todo failure HTTP responses should be queued via async HTTP
+        //event.latch.await(5, TimeUnit.SECONDS);


Maybe we should delete these comments. My feeling this was important in the past because maybe the success/failure was executed in the same thread and not off-thread like it is now. But this is a minor thing. Approving anyway.

+1, but yeah, likely does not worth to wait even more for this PR just because of it.

Maybe we can delete during some next PR, which need to do any changes in brute-force protector.

mposolda self-assigned this Apr 2, 2024

keycloak-github-bot bot added the flaky-test label Apr 2, 2024

keycloak-github-bot bot mentioned this pull request Apr 2, 2024

Flaky test: org.keycloak.testsuite.oidc.AuthenticationMethodReferenceTest#testAmrPastMaxAge #26117

Closed

douglaspalmer force-pushed the 14084 branch 3 times, most recently from b9da037 to 1a13c04 Compare April 3, 2024 21:48

mposolda requested a review from rmartinc April 5, 2024 05:38

douglaspalmer force-pushed the 14084 branch from 1a13c04 to bad470f Compare April 10, 2024 15:56

keycloak-github-bot bot mentioned this pull request Apr 10, 2024

Flaky test: org.keycloak.testsuite.admin.IdentityProviderTest#testSamlImportWithAnyEncryptionMethod #28575

Closed

keycloak-github-bot bot reviewed Apr 10, 2024

View reviewed changes

douglaspalmer force-pushed the 14084 branch 2 times, most recently from 561ecc4 to 7d2cdcc Compare April 10, 2024 23:20

keycloak-github-bot bot mentioned this pull request Apr 11, 2024

Flaky test: org.keycloak.testsuite.x509.X509BrowserLoginTest#loginWithRevalidateCertEnabledCertIsTrusted #25444

Closed

douglaspalmer force-pushed the 14084 branch from 7d2cdcc to 682fa80 Compare April 11, 2024 00:55

keycloak-github-bot bot mentioned this pull request Apr 11, 2024

Flaky test: org.keycloak.testsuite.model.DBLockTest#testTwoLocksCurrently #25794

Closed

keycloak-github-bot bot reviewed Apr 11, 2024

View reviewed changes

mposolda reviewed Apr 11, 2024

View reviewed changes

services/src/main/java/org/keycloak/services/managers/DefaultBruteForceProtector.java Outdated Show resolved Hide resolved

keycloak-github-bot bot reviewed Apr 11, 2024

View reviewed changes

rmartinc suggested changes Apr 11, 2024

View reviewed changes

...ispan/src/main/java/org/keycloak/models/sessions/infinispan/entities/LoginFailureEntity.java Outdated Show resolved Hide resolved

douglaspalmer force-pushed the 14084 branch from 682fa80 to 6b870ca Compare April 11, 2024 16:12

DefaultBruteForceProtector leverages a single thread to write success…

603bb35

…/failed events Closes keycloak#14084 Signed-off-by: Douglas Palmer <[email protected]>

douglaspalmer force-pushed the 14084 branch from 6b870ca to 603bb35 Compare April 11, 2024 16:20

keycloak-github-bot bot mentioned this pull request Apr 11, 2024

Flaky test: org.keycloak.testsuite.forms.RecoveryAuthnCodesAuthenticatorTest#test03AuthenticateRecoveryAuthnCodes #26176

Closed

keycloak-github-bot bot reviewed Apr 11, 2024

View reviewed changes

mposolda approved these changes Apr 11, 2024

View reviewed changes

douglaspalmer marked this pull request as ready for review April 11, 2024 20:32

douglaspalmer requested a review from a team as a code owner April 11, 2024 20:32

rmartinc approved these changes Apr 12, 2024

View reviewed changes

mposolda merged commit 69ba928 into keycloak:main Apr 12, 2024

DefaultBruteForceProtector leverages a single thread to write success /failed events #28368

DefaultBruteForceProtector leverages a single thread to write success /failed events #28368

Uh oh!

Conversation

douglaspalmer commented Apr 2, 2024

Uh oh!

mposolda commented Apr 5, 2024

Uh oh!

keycloak-github-bot bot left a comment

Choose a reason for hiding this comment

Uh oh!

keycloak-github-bot bot commented Apr 10, 2024

Unreported flaky test detected

org.keycloak.testsuite.organization.admin.OrganizationTest#testAttributes

org.keycloak.testsuite.organization.admin.OrganizationTest#testAttributes

Uh oh!

keycloak-github-bot bot left a comment

Choose a reason for hiding this comment

Uh oh!

keycloak-github-bot bot commented Apr 11, 2024

Unreported flaky test detected

org.keycloak.testsuite.organization.admin.OrganizationTest#testAttributes

org.keycloak.testsuite.organization.admin.OrganizationTest#testAttributes

Uh oh!

mposolda left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

keycloak-github-bot bot left a comment

Choose a reason for hiding this comment

Uh oh!

keycloak-github-bot bot commented Apr 11, 2024

Unreported flaky test detected

org.keycloak.testsuite.organization.admin.OrganizationTest#testAttributes

org.keycloak.testsuite.organization.admin.OrganizationTest#testAttributes

Uh oh!

rmartinc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

keycloak-github-bot bot commented Apr 11, 2024

Unreported flaky test detected

org.keycloak.testsuite.admin.IdentityProviderTest#testSamlImportWithAnyEncryptionMethod

org.keycloak.testsuite.admin.IdentityProviderTest#testSamlImportWithAnyEncryptionMethod

org.keycloak.testsuite.admin.IdentityProviderTest#testSamlImportWithAnyEncryptionMethod

org.keycloak.testsuite.admin.IdentityProviderTest#testSamlImportWithAnyEncryptionMethod

org.keycloak.testsuite.admin.IdentityProviderTest#testSamlImportWithAnyEncryptionMethod

org.keycloak.testsuite.admin.IdentityProviderTest#testSamlImportWithAnyEncryptionMethod

Uh oh!

keycloak-github-bot bot left a comment

Choose a reason for hiding this comment

Uh oh!

rmartinc left a comment

Choose a reason for hiding this comment

Uh oh!

rmartinc Apr 12, 2024

Choose a reason for hiding this comment

Uh oh!

mposolda Apr 12, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants