-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Allow members joining multiple organizations #29613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
49 changes: 49 additions & 0 deletions
49
...pan/src/main/java/org/keycloak/models/cache/infinispan/organization/CachedMembership.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| /* | ||
| * Copyright 2024 Red Hat, Inc. and/or its affiliates | ||
| * and other contributors as indicated by the @author tags. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.keycloak.models.cache.infinispan.organization; | ||
|
|
||
| import org.keycloak.models.RealmModel; | ||
| import org.keycloak.models.cache.infinispan.entities.AbstractRevisioned; | ||
| import org.keycloak.models.cache.infinispan.entities.InRealm; | ||
|
|
||
| public class CachedMembership extends AbstractRevisioned implements InRealm { | ||
|
|
||
| private final RealmModel realm; | ||
| private final boolean managed; | ||
| private final boolean isMember; | ||
|
|
||
| public CachedMembership(Long revision, String key, RealmModel realm, boolean managed, boolean isMember) { | ||
| super(revision, key); | ||
| this.realm = realm; | ||
| this.managed = managed; | ||
| this.isMember = isMember; | ||
| } | ||
|
|
||
| @Override | ||
| public String getRealm() { | ||
| return realm.getId(); | ||
| } | ||
|
|
||
| public boolean isManaged() { | ||
| return managed; | ||
| } | ||
|
|
||
| public boolean isMember() { | ||
| return isMember; | ||
| } | ||
| } |
48 changes: 48 additions & 0 deletions
48
...rc/main/java/org/keycloak/models/cache/infinispan/organization/CachedOrganizationIds.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| /* | ||
| * Copyright 2024 Red Hat, Inc. and/or its affiliates | ||
| * and other contributors as indicated by the @author tags. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.keycloak.models.cache.infinispan.organization; | ||
|
|
||
| import java.util.HashSet; | ||
| import java.util.Set; | ||
| import java.util.stream.Stream; | ||
|
|
||
| import org.keycloak.models.OrganizationModel; | ||
| import org.keycloak.models.RealmModel; | ||
| import org.keycloak.models.cache.infinispan.entities.AbstractRevisioned; | ||
| import org.keycloak.models.cache.infinispan.entities.InRealm; | ||
|
|
||
| public class CachedOrganizationIds extends AbstractRevisioned implements InRealm { | ||
|
|
||
| private final RealmModel realm; | ||
| private final Set<String> orgIds = new HashSet<>(); | ||
|
|
||
| public CachedOrganizationIds(Long revision, String id, RealmModel realm, Stream<OrganizationModel> organizations) { | ||
| super(revision, id); | ||
| this.realm = realm; | ||
| organizations.map(OrganizationModel::getId).forEach(orgIds::add); | ||
| } | ||
|
|
||
| @Override | ||
| public String getRealm() { | ||
| return realm.getId(); | ||
| } | ||
|
|
||
| public Set<String> getOrgIds() { | ||
| return orgIds; | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we have this method in
utils/Organizationsa remove it from here andUserStorageManager?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can but it would require moving that class to another package and increase the change set. Can you please open an issue so we can work as a follow-up, if you think it makes sense?