feat(SAML): add Artifact Binding on brokering scenarios when Keycloak is SP #29619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4888eec to
dee0a34
Compare
aa1f680 to
d826848
Compare
d826848 to
919ec34
Compare
jonkoops
previously approved these changes
Jun 13, 2024
js/apps/admin-ui/src/identity-providers/add/DescriptorSettings.tsx
Outdated
Show resolved
Hide resolved
92b6bd2
92b6bd2 to
8975c38
Compare
pedroigor
previously approved these changes
Jun 13, 2024
8975c38 to
fedfdf4
Compare
Contributor
|
I had to fix the |
pedroigor
approved these changes
Jun 13, 2024
Signed-off-by: tmorin <[email protected]>
Signed-off-by: Pedro Igor <[email protected]>
Signed-off-by: Pedro Igor <[email protected]>
Signed-off-by: Pedro Igor <[email protected]>
Signed-off-by: Pedro Igor <[email protected]>
2abca03 to
889df1f
Compare
jonkoops
approved these changes
Jun 14, 2024
Contributor
|
@tmorin Thanks for your time! Finally merged ... |
Contributor
Author
Thank you for the review and the work ! :) |
This was referenced Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of the pull request is to support ARTIFACT-BINDING in a brokering scenario when Keycloak is the Service Provider.
The PR impacts the UI when creating/configuring an Identity Provider with the SAMLv2 protocol:
The PR impacts the discovery of the SAMLv2 metadata by retrieving the URL of the Artifact Resolver when available.
The PR impacts the SAML endpoint handling the SAML artifact as well as the resolution of the assertion using the Artifact Resolver URL.
The PR impacts the documentation by adding entries about the new fields.
Closes #14073
Closes #25745