Encode realm name in console URIs #29102
Merged
+71
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this fix console uris (including the client redirect uris) did not contain the url encoded realm name and therefore were invalid. Fixes keycloak#25807 Signed-off-by: Philip Sanetra <[email protected]>
This was referenced Apr 26, 2024
Contributor
Author
|
I have fixed also the account v3. It was just a decode in the path of the router. Please @keycloak/ui take a look just in case. |
jonkoops
previously approved these changes
Apr 26, 2024
Contributor
jonkoops
left a comment
There was a problem hiding this comment.
LGTM, just wondering if the URLs could be done with less repetition.
services/src/main/java/org/keycloak/services/managers/RealmManager.java
Outdated
Show resolved
Hide resolved
services/src/main/java/org/keycloak/services/managers/RealmManager.java
Outdated
Show resolved
Hide resolved
Closes keycloak#25807 Signed-off-by: rmartinc <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #25807
This probably also closes #26108. I'll take a look but I think that with this the realm is properly checked in name and id.
The PR encodes the URLs generated when a realm is created. It also decodes the issuer to obtain the realm that was previously encoded. Tests added.
Maybe there are more issues about spaces in realms but the idea is managing them one by one. With this PR at least the realm is created and it's functional with the admin console. I'm going to file a new bug for the account console. The v2 one worked OK but v3 is failing.