Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Internal read-only attributes have precedence over unmanaged attribute policy #30534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ahus1 merged 1 commit into from
Jun 19, 2024
Merged

Internal read-only attributes have precedence over unmanaged attribute policy #30534

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions server-spi-private/src/main/java/org/keycloak/userprofile/DefaultAttributes.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,14 +94,14 @@ public DefaultAttributes(UserProfileContext context, Map<String, ?> attributes,

@Override
public boolean isReadOnly(String name) {
if (!isManagedAttribute(name)) {
return !isAllowEditUnmanagedAttribute();
}

if (isReadOnlyFromMetadata(name) || isReadOnlyInternalAttribute(name)) {
return true;
}

if (!isManagedAttribute(name)) {
return !isAllowEditUnmanagedAttribute();
}

return getMetadata(name) == null;
}

Expand Down
27 changes: 27 additions & 0 deletions ...rc/test/java/org/keycloak/testsuite/account/AccountRestServiceReadOnlyAttributesTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@
import org.keycloak.representations.userprofile.config.UPAttribute;
import org.keycloak.representations.userprofile.config.UPAttributePermissions;
import org.keycloak.representations.userprofile.config.UPConfig;
import org.keycloak.representations.userprofile.config.UPConfig.UnmanagedAttributePolicy;
import org.keycloak.services.messages.Messages;
import org.keycloak.testsuite.admin.ApiUtil;
import org.keycloak.testsuite.broker.util.SimpleHttpDefault;
Expand All @@ -47,6 +48,7 @@
import static org.hamcrest.Matchers.not;
import static org.junit.Assert.assertEquals;
import static org.hamcrest.MatcherAssert.assertThat;
import static org.junit.Assert.assertNull;
import static org.junit.Assert.assertTrue;

/**
Expand Down Expand Up @@ -144,6 +146,31 @@ public void testUpdateProfileCannotUpdateReadOnlyAttributes() throws IOException
testAccountUpdateAttributeExpectSuccess("deniedSomeAdmin");
}

@Test
public void testUpdateProfileCannotUpdateReadOnlyAttributesUnmanagedEnabled() throws IOException {
UPConfig configuration = testRealm().users().userProfile().getConfiguration();
UnmanagedAttributePolicy unmanagedAttributePolicy = configuration.getUnmanagedAttributePolicy();
configuration.setUnmanagedAttributePolicy(UnmanagedAttributePolicy.ENABLED);
getCleanup().addCleanup(() -> {
configuration.setUnmanagedAttributePolicy(unmanagedAttributePolicy);
testRealm().users().userProfile().update(configuration);
});
testRealm().users().userProfile().update(configuration);
UserRepresentation user = SimpleHttpDefault.doGet(getAccountUrl(null), httpClient).auth(tokenUtil.getToken()).asJson(UserRepresentation.class);
UserResource adminUserResource = ApiUtil.findUserByUsernameId(testRealm(), user.getUsername());
org.keycloak.representations.idm.UserRepresentation adminUserRep = adminUserResource.toRepresentation();
adminUserRep.singleAttribute("deniedFoo", "foo");
adminUserResource.update(adminUserRep);
adminUserResource = ApiUtil.findUserByUsernameId(testRealm(), user.getUsername());
adminUserRep = adminUserResource.toRepresentation();
assertEquals("foo", adminUserRep.getAttributes().get("deniedFoo").get(0));
assertNull(user.getAttributes());
updateAndGet(user);
adminUserResource = ApiUtil.findUserByUsernameId(testRealm(), user.getUsername());
adminUserRep = adminUserResource.toRepresentation();
assertEquals("foo", adminUserRep.getAttributes().get("deniedFoo").get(0));
}

private void testAccountUpdateAttributeExpectFailure(String attrName) throws IOException {
testAccountUpdateAttributeExpectFailure(attrName, false);
}
Expand Down