Issue 30525 #30692
Merged
Issue 30525 #30692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
francis-pouatcha
commented
Jun 24, 2024
- Closes Enhance Verifiable Credential Signing Service Flexibility and Key Rotation #30525
- Removed mandatory nbf from credential as per spec.
- Changed 'code' access token request key, to 'pre-authorized_code' for the correponding grant type
…bject as defined in OpenID for Verifiable Credential Issuance specification. Signed-off-by: Francis Pouatcha <[email protected]>
vct claim is mandatory for sd-jwt. Can be ommited by other formats display shall be an array display object can be configured using an escaped json, as dot notation will be cumbersome with arrays proof_types_supported can be configured using an escaped json, as each proof type has different configuration parameters. Signed-off-by: Francis Pouatcha <[email protected]>
Signed-off-by: Francis Pouatcha <[email protected]>
Signed-off-by: Francis Pouatcha <[email protected]>
Signed-off-by: Francis Pouatcha <[email protected]>
Signed-off-by: Francis Pouatcha <[email protected]>
Signed-off-by: Francis Pouatcha <[email protected]>
Signed-off-by: Francis Pouatcha <[email protected]>
Signed-off-by: Francis Pouatcha <[email protected]>
…t-type:pre-authorized_code to pre-authorized_code instead of code as per spec. Signed-off-by: Francis Pouatcha <[email protected]>
…t-type:pre-authorized_code to pre-authorized_code instead of code as per spec. Signed-off-by: Francis Pouatcha <[email protected]>
… as per spec. Signed-off-by: Francis Pouatcha <[email protected]>
Signed-off-by: Francis Pouatcha <[email protected]>
Signed-off-by: Francis Pouatcha <[email protected]>
Contributor
Author
Signed-off-by: Francis Pouatcha <[email protected]>
This was referenced Jul 17, 2024
Closed
Contributor
|
@francis-pouatcha I hope to merge if @wistefan and @tnorimat approve this PR to make sure that they are fine with latest changes. |
Contributor
|
@mposolda @francis-pouatcha Hello, I will re-review the PR. |
tnorimat
suggested changes
Jul 22, 2024
Contributor
tnorimat
left a comment
There was a problem hiding this comment.
@francis-pouatcha Thank you. I added review commnets. Could you check them?
services/src/main/java/org/keycloak/protocol/oid4vc/OID4VCLoginProtocolFactory.java
Show resolved
Hide resolved
services/src/main/java/org/keycloak/protocol/oid4vc/issuance/OID4VCIssuerEndpoint.java
Outdated
Show resolved
Hide resolved
services/src/main/java/org/keycloak/protocol/oid4vc/issuance/OID4VCIssuerEndpoint.java
Outdated
Show resolved
Hide resolved
services/src/main/java/org/keycloak/protocol/oid4vc/issuance/OID4VCIssuerEndpoint.java
Outdated
Show resolved
Hide resolved
services/src/main/java/org/keycloak/protocol/oid4vc/issuance/OID4VCIssuerEndpoint.java
Outdated
Show resolved
Hide resolved
...test/java/org/keycloak/testsuite/oid4vc/issuance/signing/OID4VCSdJwtIssuingEndpointTest.java
Outdated
Show resolved
Hide resolved
...test/java/org/keycloak/testsuite/oid4vc/issuance/signing/OID4VCSdJwtIssuingEndpointTest.java
Outdated
Show resolved
Hide resolved
...test/java/org/keycloak/testsuite/oid4vc/issuance/signing/OID4VCSdJwtIssuingEndpointTest.java
Outdated
Show resolved
Hide resolved
...test/java/org/keycloak/testsuite/oid4vc/issuance/signing/OID4VCSdJwtIssuingEndpointTest.java
Outdated
Show resolved
Hide resolved
...test/java/org/keycloak/testsuite/oid4vc/issuance/signing/OID4VCSdJwtIssuingEndpointTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Francis Pouatcha <[email protected]>
Signed-off-by: Francis Pouatcha <[email protected]>
2 tasks
Signed-off-by: Francis Pouatcha <[email protected]>
Contributor
Author
|
@tnorimat i shall have all review comments addressed. |
Contributor
|
@francis-pouatcha Thank you. |
mposolda
approved these changes
Jul 24, 2024
Contributor
mposolda
left a comment
There was a problem hiding this comment.
@francis-pouatcha @tnorimat Thanks for the participation and review of this PR!
stianst
pushed a commit
to stianst/keycloak
that referenced
this pull request
Jul 25, 2024
…ation(keycloak#30692) closes keycloak#30525 Signed-off-by: Francis Pouatcha <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.