Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@mabartos
Copy link
Contributor

Closes #30355

@mabartos
Copy link
Contributor Author

mabartos commented Jun 25, 2024

@vmuzikar @keycloak/cloud-native I believe it's sufficient to resolve the parent issue. Are you okay with that, or do you have any suggestions?

@mabartos mabartos requested a review from vmuzikar June 25, 2024 08:37
@mabartos mabartos marked this pull request as ready for review June 25, 2024 08:37
@mabartos mabartos requested review from a team as code owners June 25, 2024 08:37
@mabartos
Copy link
Contributor Author

mabartos commented Jun 25, 2024

@vmuzikar Might be better now. PTAL

I added more general info to the advanced configuration and kept the more specific message related to the mgmt interface to the related subsection about mgmt interface.

Copy link
Contributor

@vmuzikar vmuzikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mabartos Thank you for this docs enhancement!

Added some suggestions to the wording but I'm not a native speaker so I don't consider it blocking. :D

Closes keycloak#30355

Co-authored-by: Václav Muzikář <[email protected]>
Signed-off-by: Martin Bartoš <[email protected]>
@mabartos
Copy link
Contributor Author

@vmuzikar Thanks! Looks better :)) Updated

@vmuzikar vmuzikar enabled auto-merge (squash) June 26, 2024 15:46
@vmuzikar vmuzikar merged commit 0a88851 into keycloak:main Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New operator failing on health checks

2 participants