Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Remove java.util.Date from VerifiableCredential#30920

Merged
mposolda merged 3 commits intokeycloak:mainfrom
Captain-P-Goldfish:date-for-instant
Jul 18, 2024
Merged

Remove java.util.Date from VerifiableCredential#30920
mposolda merged 3 commits intokeycloak:mainfrom
Captain-P-Goldfish:date-for-instant

Conversation

@Captain-P-Goldfish
Copy link
Contributor

@Captain-P-Goldfish Captain-P-Goldfish commented Jun 28, 2024

Ban java.util.Date from VerifiableCredential in exchange for java.time.Instant

fixes #30918
relatesTo #26328

@Captain-P-Goldfish Captain-P-Goldfish requested review from a team as code owners June 28, 2024 12:56
This was referenced Jun 28, 2024
Closed
Closed
@keycloak-github-bot keycloak-github-bot bot mentioned this pull request Jul 7, 2024
Closed
@Captain-P-Goldfish Captain-P-Goldfish mentioned this pull request Jul 10, 2024
Open
@mposolda
Copy link
Contributor

mposolda commented Jul 11, 2024

@wistefan @francis-pouatcha @tnorimat Anyone of you available to review this please?

@mposolda
Copy link
Contributor

mposolda commented Jul 11, 2024

One point: This PR adds a dependency to keycloak-core module of fasterxml jsr310. That one is already bundled in Keycloak distribution and hence should be OK to include.

@Captain-P-Goldfish
Copy link
Contributor Author

Captain-P-Goldfish commented Jul 11, 2024

I needed to add the dependency because this specific module did not know of the JavaTimeModule from jackson.

@tnorimat
Copy link
Contributor

tnorimat commented Jul 12, 2024

@mposolda the main point for the PR is whether fasterxml jsr310 is acceptable or not. Could you determine it by your team?

@mposolda
Copy link
Contributor

mposolda commented Jul 16, 2024

@mposolda the main point for the PR is whether fasterxml jsr310 is acceptable or not. Could you determine it by your team?

@tnorimat Yes, adding this dependency in the core module is OK as the library com.fasterxml.jackson.datatype.jackson-datatype-jsr310*.jar is already bundled in Keycloak (in the directory lib/lib/main of the Keycloak quarkus distribution) and already productized in RH . Thanks for pointing that.

@tnorimat
Copy link
Contributor

tnorimat commented Jul 17, 2024

@mposolda I see. I will review the PR.

tnorimat
tnorimat approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@tnorimat tnorimat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mposolda
Copy link
Contributor

mposolda commented Jul 17, 2024

@tnorimat Thanks for the review!

@Captain-P-Goldfish Could you please rebase this on top of latest Keycloak main to resolve the conflict? Hopefully that will help with the failing test as well.

@Captain-P-Goldfish Captain-P-Goldfish requested a review from a team as a code owner July 17, 2024 19:45
@Captain-P-Goldfish
Copy link
Contributor Author

Captain-P-Goldfish commented Jul 17, 2024

darn... seems like I broke something during rebase...

Captain-P-Goldfish and others added 3 commits July 17, 2024 21:52
@Captain-P-Goldfish
Ban java.util.Date from VerifiableCredential in exchange for java.tim…
509c988 
…e.Instant

fixes keycloak#30918

Signed-off-by: Pascal Knüppel <[email protected]>
@Captain-P-Goldfish
Fix unit tests
9235bb1 
Signed-off-by: Captain-P-Goldfish <[email protected]>
@Captain-P-Goldfish
Remove unused imports
f706f52 
Signed-off-by: Captain-P-Goldfish <[email protected]>
@Captain-P-Goldfish
Copy link
Contributor Author

Captain-P-Goldfish commented Jul 17, 2024

fixed

tnorimat
tnorimat approved these changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@tnorimat tnorimat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mposolda
mposolda approved these changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@mposolda mposolda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Captain-P-Goldfish @tnorimat Thanks!

@mposolda mposolda merged commit 018a080 into keycloak:main Jul 18, 2024
This was referenced Jul 19, 2024
Merged
Closed
stianst pushed a commit to stianst/keycloak that referenced this pull request Jul 25, 2024
@Captain-P-Goldfish @stianst
Remove java.util.Date from VerifiableCredential (keycloak#30920)
93b2358 
closes keycloak#30918

Signed-off-by: Pascal Knüppel <[email protected]>
Signed-off-by: Captain-P-Goldfish <[email protected]>
@Captain-P-Goldfish Captain-P-Goldfish deleted the date-for-instant branch July 26, 2024 20:35
@Captain-P-Goldfish Captain-P-Goldfish restored the date-for-instant branch July 26, 2024 20:35
@Captain-P-Goldfish Captain-P-Goldfish deleted the date-for-instant branch August 1, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mposolda mposolda mposolda approved these changes

+1 more reviewer

@tnorimat tnorimat tnorimat approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mposolda mposolda

@tnorimat tnorimat

Labels

flaky-test team/cloud-native team/core-clients team/core-iam team/ui

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

VerifiableCredential: Exchange java.util.Date for java.time.Instant

3 participants

@Captain-P-Goldfish @mposolda @tnorimat