Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix sub-flow name / description editing #30948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
agagancarczyk merged 1 commit into from
Jul 1, 2024
Merged

Fix sub-flow name / description editing #30948

agagancarczyk merged 1 commit into from
Jul 1, 2024
+1 −1

Conversation

@mruzicka
Copy link
Contributor

@mruzicka mruzicka commented Jun 30, 2024 •
edited
Loading

Fixes a mismatch between frontend and backend in the name of the property used to hold the name of a sub-flow which breaks the editing of the sub-flow name / description.

Fixes #30947.

@mruzicka mruzicka requested a review from a team as a code owner June 30, 2024 16:53
@agagancarczyk
Copy link
Contributor

agagancarczyk commented Jul 1, 2024

@mruzicka Thanks for your contribution. The fix looks good to me. Could you also add a test for this?

@mruzicka
Copy link
Contributor Author

mruzicka commented Jul 1, 2024 •
edited
Loading

@agagancarczyk, I'm afraid I don't have the bandwidth to add the test, sorry.
If there were some tests targeting the sub-flow editing functionality I might be able to extend them to cover this particular issue but unfortunately I couldn't find any. (I searched in https://github.com/keycloak/keycloak/blob/0d6ecab862f68741cc83e6418de32653a97f61f9/js/apps/admin-ui/cypress/e2e/authentication_test.spec.ts - are there perhaps other tests covering the functionality elsewhere?)

@agagancarczyk
Copy link
Contributor

agagancarczyk commented Jul 1, 2024

@agagancarczyk, I'm afraid I don't have the bandwidth to add the test, sorry. If there were some tests targeting the sub-flow editing functionality I might be able to extend them to cover this particular issue but unfortunately I couldn't find any. (I searched in https://github.com/keycloak/keycloak/blob/0d6ecab862f68741cc83e6418de32653a97f61f9/js/apps/admin-ui/cypress/e2e/authentication_test.spec.ts - are there perhaps other tests covering the functionality elsewhere?)

Thanks @mruzicka , no worries, I'll add the test. The test is just missing.

@agagancarczyk agagancarczyk self-assigned this Jul 1, 2024
@agagancarczyk agagancarczyk merged commit 53fa901 into keycloak:main Jul 1, 2024
@agagancarczyk agagancarczyk mentioned this pull request Jul 1, 2024
Closed
2 tasks
@agagancarczyk agagancarczyk added this to the 26.0.0 milestone Jul 1, 2024
@agagancarczyk agagancarczyk mentioned this pull request Jul 2, 2024
Merged
@agagancarczyk agagancarczyk removed this from the 26.0.0 milestone Jul 2, 2024
@mruzicka mruzicka deleted the flow_edit branch July 2, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@agagancarczyk agagancarczyk agagancarczyk approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@agagancarczyk agagancarczyk

Labels

team/ui

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Error when trying to edit authentication sub-flow name / description

3 participants

@mruzicka @agagancarczyk @jonkoops