Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Backport to Fix sub-flow name/ description editing #30990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
agagancarczyk merged 1 commit into from
Jul 2, 2024
+1 −1
Merged

Backport to Fix sub-flow name/ description editing #30990

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion js/apps/admin-ui/src/authentication/components/EditFlow.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ export const EditFlow = ({ execution, onRowChange }: EditFlowProps) => {
<FormProvider {...form}>
<TextControl
name="name"
label={t("name")}
label={t("displayName")}
Copy link
Contributor

@mruzicka mruzicka Jul 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@agagancarczyk, I'm not quite sure this fixes the issue, I had to change the value of the name attribute to fix it, while you are changing the value of the label attribute here.

Cf. with https://github.com/keycloak/keycloak/pull/30948/files

Copy link
Contributor

@mruzicka mruzicka Jul 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@agagancarczyk, @edewit it is still broken in 25.0.2

labelIcon={t("flowNameHelp")}
rules={{ required: { value: true, message: t("required") } }}
/>
Expand Down