Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Pin Ansible version for Aurora Store IT tests to 9.x.y stream #30212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ahus1 merged 1 commit into from
Jun 6, 2024
Merged

Pin Ansible version for Aurora Store IT tests to 9.x.y stream #30212

ahus1 merged 1 commit into from
Jun 6, 2024

Conversation

@ryanemerson
Copy link
Contributor

@ryanemerson ryanemerson commented Jun 6, 2024

@ryanemerson ryanemerson requested a review from a team as a code owner June 6, 2024 13:04
@ahus1
Copy link
Contributor

ahus1 commented Jun 6, 2024

@ryanemerson - thank you for this PR.

Looking at the fix, I searched keycloak-benchmark and found a similar comment pip3 install --user boto3 botocore there, but which doesn't contain the ansible part. As it still worked in the last nightly run, I wonder if it would also be sufficient to remove the ansible part here instead of adding the pinned version, or if we should adapt the command in keycloak-benchmark to look the same like this one.

@ryanemerson
Copy link
Contributor Author

ryanemerson commented Jun 6, 2024 •
edited
Loading

@ahus1 In the keycloak-benchmark repo we state that a prerequisite for running the benchmark is to "Install Ansible CLI (on Fedora, use dnf install ansible)". As we never execute aws_ec2.sh in the keycloak-benchmark actions, ansible is not included in the pip install command. Whereas here we execute using actions, so we need to install all dependencies including ansible.

@keycloak-github-bot keycloak-github-bot bot mentioned this pull request Jun 6, 2024
Closed
@ahus1
Copy link
Contributor

ahus1 commented Jun 6, 2024

As we never execute aws_ec2.sh in the keycloak-benchmark actions, ansible is not included in the pip install command.

Not so sure about that - IMHO we use it to run the benchmarks. See https://github.com/keycloak/keycloak-benchmark/blob/406553252e6c5eee7ae0d2d2869e1838d101adfd/.github/actions/ec2-create-instances/action.yml#L16

Do you want to reconsider, or should I merge?

@ryanemerson
Copy link
Contributor Author

ryanemerson commented Jun 6, 2024

Argh sorry, I was very wrong indeed! I completely forgot about the benchmark execution 🙃

Looking at keycloak-benchmark some more, it seems we use ansible-core that's actually included with the Ubuntu distribution which is version 2.12.0-1 https://packages.ubuntu.com/jammy/ansible-core, whereas we have an issue with 2.17.x. So we don't need to change anything there.

I think the Keycloak repository should work using the same method as ^, so maybe I should change this PR so we use the same approach as keycloak-benchmark?

@ahus1
Copy link
Contributor

ahus1 commented Jun 6, 2024

I think the Keycloak repository should work using the same method as ^, so maybe I should change this PR so we use the same approach as keycloak-benchmark?

I'd think so, too. Please give it a try.

Looking at the commands, I see that we call ansible-galaxy before calling pip3 in both places, so IMHO we assume Ansible is pre-installed each time.

@ahus1 ahus1 self-assigned this Jun 6, 2024
@keycloak-github-bot keycloak-github-bot bot mentioned this pull request Jun 6, 2024
Closed
@keycloak-github-bot
Copy link

keycloak-github-bot bot commented Jun 6, 2024

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.model.user.UserModelTest#testAddRemoveUsersInTheSameGroupConcurrent

Keycloak CI - Store Model Tests

java.util.ConcurrentModificationException: java.util.ConcurrentModificationException
	at java.base/jdk.internal.reflect.DirectConstructorHandleAccessor.newInstance(DirectConstructorHandleAccessor.java:62)
	at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:502)
	at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:486)
	at java.base/java.util.concurrent.ForkJoinTask.getThrowableException(ForkJoinTask.java:540)
...

Report flaky test

org.keycloak.testsuite.model.session.SessionTimeoutsTest#testOfflineUserClientIdleTimeoutSmallerThanSessionOneRefresh

Keycloak CI - Store Model Tests

java.lang.AssertionError: expected null, but was:<org.keycloak.models.sessions.infinispan.AuthenticatedClientSessionAdapter@48b32cb7>
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.failNotNull(Assert.java:756)
	at org.junit.Assert.assertNull(Assert.java:738)
	at org.junit.Assert.assertNull(Assert.java:748)
...

Report flaky test

org.keycloak.testsuite.model.user.UserModelTest#testAddRemoveUserConcurrent

Keycloak CI - Store Model Tests

java.util.ConcurrentModificationException: java.util.ConcurrentModificationException
	at java.base/jdk.internal.reflect.DirectConstructorHandleAccessor.newInstance(DirectConstructorHandleAccessor.java:62)
	at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:502)
	at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:486)
	at java.base/java.util.concurrent.ForkJoinTask.getThrowableException(ForkJoinTask.java:540)
...

Report flaky test

org.keycloak.testsuite.model.user.UserModelTest#testAddRemoveUserConcurrent

Keycloak CI - Store Model Tests

java.util.ConcurrentModificationException: java.util.ConcurrentModificationException
	at java.base/jdk.internal.reflect.DirectConstructorHandleAccessor.newInstance(DirectConstructorHandleAccessor.java:62)
	at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:502)
	at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:486)
	at java.base/java.util.concurrent.ForkJoinTask.getThrowableException(ForkJoinTask.java:540)
...

Report flaky test

keycloak-github-bot[bot]
keycloak-github-bot bot reviewed Jun 6, 2024
View reviewed changes
Copy link

@keycloak-github-bot keycloak-github-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

keycloak-github-bot[bot]
keycloak-github-bot bot reviewed Jun 6, 2024
View reviewed changes
Copy link

@keycloak-github-bot keycloak-github-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
Copy link

keycloak-github-bot bot commented Jun 6, 2024

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.model.user.UserModelTest#testAddRemoveUsersInTheSameGroupConcurrent

Keycloak CI - Store Model Tests

java.util.ConcurrentModificationException: java.util.ConcurrentModificationException
	at java.base/jdk.internal.reflect.DirectConstructorHandleAccessor.newInstance(DirectConstructorHandleAccessor.java:62)
	at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:502)
	at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:486)
	at java.base/java.util.concurrent.ForkJoinTask.getThrowableException(ForkJoinTask.java:540)
...

Report flaky test

org.keycloak.testsuite.model.session.SessionTimeoutsTest#testOfflineUserClientIdleTimeoutSmallerThanSessionOneRefresh

Keycloak CI - Store Model Tests

java.lang.AssertionError: expected null, but was:<org.keycloak.models.sessions.infinispan.AuthenticatedClientSessionAdapter@48b32cb7>
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.failNotNull(Assert.java:756)
	at org.junit.Assert.assertNull(Assert.java:738)
	at org.junit.Assert.assertNull(Assert.java:748)
...

Report flaky test

org.keycloak.testsuite.model.user.UserModelTest#testAddRemoveUserConcurrent

Keycloak CI - Store Model Tests

java.util.ConcurrentModificationException: java.util.ConcurrentModificationException
	at java.base/jdk.internal.reflect.DirectConstructorHandleAccessor.newInstance(DirectConstructorHandleAccessor.java:62)
	at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:502)
	at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:486)
	at java.base/java.util.concurrent.ForkJoinTask.getThrowableException(ForkJoinTask.java:540)
...

Report flaky test

org.keycloak.testsuite.model.user.UserModelTest#testAddRemoveUserConcurrent

Keycloak CI - Store Model Tests

java.util.ConcurrentModificationException: java.util.ConcurrentModificationException
	at java.base/jdk.internal.reflect.DirectConstructorHandleAccessor.newInstance(DirectConstructorHandleAccessor.java:62)
	at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:502)
	at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:486)
	at java.base/java.util.concurrent.ForkJoinTask.getThrowableException(ForkJoinTask.java:540)
...

Report flaky test

@ryanemerson
Copy link
Contributor Author

ryanemerson commented Jun 6, 2024

Aurora CI job passing on my fork with the latest changes: https://github.com/ryanemerson/keycloak/actions/runs/9403943881/job/25901942052

ahus1
ahus1 approved these changes Jun 6, 2024
View reviewed changes
Copy link
Contributor

@ahus1 ahus1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR - we are now better aligned with the KCB project than ever!

@ahus1 ahus1 merged commit 25cf961 into keycloak:main Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahus1 ahus1 ahus1 approved these changes

+1 more reviewer

@keycloak-github-bot keycloak-github-bot[bot] keycloak-github-bot[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@ahus1 ahus1

Labels

flaky-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Keycloak CI - failure in Store IT (aurora-postgres)

2 participants

@ryanemerson @ahus1