Specific hostname to bind to for H2 in dev mode #30222
Conversation
|
@pedroigor / @Pepo48 / @vmuzikar - I'd like to get your feedback on this, and if AUTO_SERVER mode is useful for Keycloak (either when developing, or in tests). If not, we could simplify the setup. See the H2 for more docs on this: https://www.h2database.com/html/features.html#auto_mixed_mode |
|
@ahus1 Thank you for the PR. I'm not aware of any reason to keep Without it, we don't need to set |
Yes, this is my understanding. Do we use in the test suite a setup with Also asking @pedroigor, @sguilhen and @vramik. Thanks! |
This avoids problems if the hostname can't be resolved by InetAddress.getLocalHost() Closes keycloak#26042 Signed-off-by: Alexander Schwartz <[email protected]>
09ec315 to
23278a1
Compare
Closes keycloak#28311 Signed-off-by: Alexander Schwartz <[email protected]>
|
@vmuzikar - with the removal of AUTO_SERVER, it is now no longer possible to run the cluster tests with H2, and instead you'll need to use a real database. WDYT? If you think running it with H2 makes things simpler, I'll need to dig deeper into this to figure out how to pass the DB URL options to Quarkus (the CLI allows it, but IMHO the build isn't equipped for that). |
|
@ahus1 IMHO that's something for the Core Teams to decide. It is true that is is a bit inconvenient to use a real DB. On the other hand, we should not be including stuff in the dist that is required for tests only... |
There was a problem hiding this comment.
@ahus1 I would only keep AUTO_SERVER=true because it is useful during dev when running multiple instances. I think because of cluster tests and local dev we have this set.
I remember a long time ago solving problems with that setting, probably when enabling cluster tests to quarkus. But you are solving it differently (and better) now.
But if @mposolda thinks otherwise, I don't mind removing it.
Avoids problems if the hostname can't be resolved by InetAddress.getLocalHost()
I assume the AUTO_MODE set up here is still useful if multiple instances of Keycloak running from the same folder make sense. If it doesn't make sense, let me know.
Closes #26042