Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@nicolabeghin
Copy link
Contributor

@nicolabeghin nicolabeghin commented Jun 10, 2024

Closes #30300

ref. @cgeorgilakis @ahus1 from original commit 4bca804

Upgrade to Keycloak 25 - Table 'USER_CONSENT' is specified twice on MySQL/MariaDB database

Signed-off-by: Nicola Beghin <[email protected]>
@ahus1 ahus1 changed the title Fix for keycloak/keycloak#30300 - Upgrade to Keycloak 25 - Table 'USER_CONSENT' is specified twice on MySQL/MariaDB database Upgrade to Keycloak 25 - Table 'USER_CONSENT' is specified twice on MySQL/MariaDB database Jun 10, 2024
@ahus1 ahus1 requested a review from sguilhen June 10, 2024 15:19
Copy link
Contributor

@vramik vramik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@stianst stianst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this will be included in 26, and probably backported to 25.0.1, what happens in the case someone has already upgraded to 25.0.0?

@pedroigor
Copy link
Contributor

As this will be included in 26, and probably backported to 25.0.1, what happens in the case someone has already upgraded to 25.0.0?

I'm not sure, but the hash is based on the id and it won't run again. @sguilhen Makes sense?

@sguilhen
Copy link
Contributor

sguilhen commented Jun 13, 2024

I'm not 100% sure how the checksum is calculated in Liquibase - it is definitely not based on the id. I believe it is calculated based on the SQL output of the changeset.

@stianst I've tested this scenario. Started Keycloak 25 using a supported version of MariaDB, changeset was executed without errors. Then migrated to a 999-SNAPSHOT version including this change. The migration ran fine, it didn't complain about checksums. So I don't think it will a problem for those who already migrated to 25.

The question is, should we do it given that users on supported versions of MariaDB don't run into any issues and the upgrade to 25 is problematic only for people running unsupported versions of the DB?

@pedroigor pedroigor merged commit 5192275 into keycloak:main Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade to Keycloak 25 - Table 'USER_CONSENT' is specified twice on MySQL/MariaDB database

5 participants