Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@dasniko
Copy link
Contributor

@dasniko dasniko commented Jun 10, 2024

closes #30302

@mposolda
Copy link
Contributor

mposolda commented Jun 10, 2024

@ahus1 Do you please have a chance to review since you are the original author of #27656 ? I am not 100% sure if we want to restore "public" methods back or if they were removed on purpose...

The class SimpleHttp is private API, so there is not guarantee that methods are backwards compatible. Leaving to you to decide how to handle this...

@ahus1
Copy link
Contributor

ahus1 commented Jun 11, 2024

@dasniko, @mposolda - I'm ok with this change as an intermediate fix until we have a public API for this.

The original PR removed public access to those methods as it was only safe to use them with the max length parameter. The new ones will retrieve the max length from the session and are therefore safe to use - so I'm approving this PR.

@dasniko - I assume you want this fix also available in a KC25 patch release. One this one is merged, please create a backport PR for the KC25 release branch with these changes.

@ahus1 ahus1 merged commit 72f994d into keycloak:main Jun 11, 2024
@dasniko
Copy link
Contributor Author

dasniko commented Jun 11, 2024

@ahus1 Backport PR: #30350

Thanks!

@dasniko dasniko deleted the simplehttp branch June 11, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Methods of SimpleHttp are after change now too much protected

3 participants