Add missing space #30394
Add missing space #30394
Conversation
|
@wimdeblauwe Thank you for the fix! Could you please signoff your commit? https://github.com/keycloak/keycloak/pull/30394/checks?check_run_id=26165830605 |
|
@wimdeblauwe did you try to render it locally? As ifeval is a block preprocessor element it needs to be on the start of a new line, so we might be missing a newline instead? |
|
I did not render it locally. I have never build Keycloak or the documentation. I just saw the wrong text on the website and thought I might be able to create my smallest PR ever :) Would be good if somebody could validate that it really fixes the problem. |
|
I did build it locally and can confirm the problem still persists, as hinted by @ahus1. |
Fix the website on https://www.keycloak.org/server/db showing some asciidoc related `ifeval` text Closes keycloak#30417 Signed-off-by: Wim Deblauwe <[email protected]>
Closes keycloak#30417 Signed-off-by: Alexander Schwartz <[email protected]>
|
I've pushed another commit, and also linked this to an issue so we can better backport it to KC25. See below a screenshot of the newly rendered text. |
|
@vmuzikar - please review when you have the time. Thanks! |
vmuzikar
left a comment
There was a problem hiding this comment.
@ahus1 @wimdeblauwe LGTM, thank you.
Fix the website on https://www.keycloak.org/server/db showing some asciidoc related
ifevaltextCloses #30417