Thanks to visit codestin.com
Credit goes to github.com

Skip to content

added admin-ui to the distribution#31404

Merged
stianst merged 2 commits intomainfrom
admin-ui-distribution
Jul 19, 2024
Merged

added admin-ui to the distribution#31404
stianst merged 2 commits intomainfrom
admin-ui-distribution

Conversation

@edewit
Copy link
Contributor

@edewit edewit commented Jul 18, 2024

@edewit
added admin-ui to the distribution
a3948b5 
Signed-off-by: Erik Jan de Wit <[email protected]>
@edewit edewit requested a review from a team as a code owner July 18, 2024 10:08
@edewit
added lib build execution
1152ba7 
Signed-off-by: Erik Jan de Wit <[email protected]>
@edewit edewit requested a review from a team as a code owner July 18, 2024 10:25
keycloak-github-bot[bot]
keycloak-github-bot bot reviewed Jul 18, 2024
View reviewed changes
Copy link

@keycloak-github-bot keycloak-github-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
Copy link

keycloak-github-bot bot commented Jul 18, 2024

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.saml.AudienceProtocolMappersTest#testAudienceResolveFullScope

Keycloak CI - Base IT (6)

jakarta.ws.rs.InternalServerErrorException: HTTP 500 Internal Server Error
	at org.jboss.resteasy.client.jaxrs.internal.ClientInvocation.handleErrorStatus(ClientInvocation.java:250)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.extractors.DefaultEntityExtractorFactory$3.extractEntity(DefaultEntityExtractorFactory.java:41)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.ClientInvoker.invokeSync(ClientInvoker.java:136)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.ClientInvoker.invoke(ClientInvoker.java:103)
...

Report flaky test

org.keycloak.testsuite.admin.AttackDetectionResourceTest#test

Keycloak CI - Store IT (mssql)

java.lang.AssertionError: expected:<2> but was:<3>
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.failNotEquals(Assert.java:835)
	at org.junit.Assert.assertEquals(Assert.java:120)
	at org.junit.Assert.assertEquals(Assert.java:146)
...

Report flaky test

@edewit edewit self-assigned this Jul 18, 2024
@stianst stianst merged commit e99f99b into main Jul 19, 2024
@stianst stianst deleted the admin-ui-distribution branch July 19, 2024 08:36
edewit added a commit to edewit/keycloak that referenced this pull request Jul 24, 2024
@edewit
added admin-ui to the distribution (keycloak#31404)
6206fda 
* added admin-ui to the distribution

Signed-off-by: Erik Jan de Wit <[email protected]>

* added lib build execution

Signed-off-by: Erik Jan de Wit <[email protected]>

---------

Signed-off-by: Erik Jan de Wit <[email protected]>
(cherry picked from commit e99f99b)
@edewit edewit mentioned this pull request Jul 24, 2024
Closed
edewit added a commit to edewit/keycloak that referenced this pull request Jul 25, 2024
@edewit
added admin-ui to the distribution (keycloak#31404)
acd3f38 
* added admin-ui to the distribution

Signed-off-by: Erik Jan de Wit <[email protected]>

* added lib build execution

Signed-off-by: Erik Jan de Wit <[email protected]>

---------

Signed-off-by: Erik Jan de Wit <[email protected]>
(cherry picked from commit e99f99b)
@stianst stianst mentioned this pull request Jul 25, 2024
Closed
stianst pushed a commit to stianst/keycloak that referenced this pull request Jul 25, 2024
@edewit @stianst
added admin-ui to the distribution (keycloak#31404)
c23a734 
* added admin-ui to the distribution

Signed-off-by: Erik Jan de Wit <[email protected]>

* added lib build execution

Signed-off-by: Erik Jan de Wit <[email protected]>

---------

Signed-off-by: Erik Jan de Wit <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stianst stianst stianst approved these changes

+2 more reviewers

@keycloak-github-bot keycloak-github-bot[bot] keycloak-github-bot[bot] left review comments

@jonkoops jonkoops jonkoops approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@edewit edewit

Labels

flaky-test team/ui

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@edewit @jonkoops @stianst