fix: additional consolidation / refinement of argument parsing #31448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes: keycloak#26339 Signed-off-by: Steve Hawkins <[email protected]>
Contributor
Author
|
@vmuzikar @mabartos @Pepo48 I noticed that this also fixes a bug - the previous refinements to the parsing logic were excluding --spi... value options (without an '=') from being picked up by the Config. This was not intentional, just a side effect of the focus on our primary options. So this can be considered / narrowed for backport as well. |
mabartos
approved these changes
Jul 24, 2024
Contributor
There was a problem hiding this comment.
@shawkins Much cleaner! And good job for spotting the bug around spi props values. Agree to backport the bug fix.
For better addressing, it'd be good to create a separate issue for the bug and reference also this PR there. WDYT?
Contributor
Author
Captured as #31578 |
stianst
pushed a commit
to stianst/keycloak
that referenced
this pull request
Jul 25, 2024
…oak#31448) closes: keycloak#26339 Signed-off-by: Steve Hawkins <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #26339 #31578
Took another pass over the various parsing we are doing to make another consolidation. It is possible that we could do the initial parsing / filtering to a better structure than just a list of strings to avoid the key parsing in subsequent passes. However that changes quite a bit of logic so it doesn't seem worth it.