Remove TrustedHostClientRegistrationPolicyTest#testGithubDomain #31512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes keycloak#29271 Signed-off-by: rmartinc <[email protected]>
mposolda
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #29271
Just removing the test
TrustedHostClientRegistrationPolicyTest#testGithubDomainbecause it's causing issues in some regions. The test tries to check reverse lookup usinggithub.combut it seems that in different regions the reverse lookup returns microsoft (not github) domain. In general the previous testtestGoogleCrawlBotis documented to work and this one was added to use more than one IP/hostname pair. So we are already covered by the other test but using just one IP.