Thanks to visit codestin.com
Credit goes to github.com

Skip to content

All CURL commands should check the HTTP response code #31602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mhajas merged 1 commit into from
Jul 26, 2024
Merged

All CURL commands should check the HTTP response code #31602

mhajas merged 1 commit into from
Jul 26, 2024

Conversation

@ahus1
Copy link
Contributor

@ahus1 ahus1 commented Jul 25, 2024

Closes #31598

@ahus1 ahus1 self-assigned this Jul 25, 2024
@keycloak-github-bot keycloak-github-bot bot mentioned this pull request Jul 25, 2024
Closed
keycloak-github-bot[bot]
keycloak-github-bot bot reviewed Jul 25, 2024
View reviewed changes
Copy link

@keycloak-github-bot keycloak-github-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
Copy link

keycloak-github-bot bot commented Jul 25, 2024

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.forms.BrowserFlowTest#testLoginWithWithNoOTPCredential

Keycloak CI - Forms IT (firefox)

java.lang.AssertionError
	at org.junit.Assert.fail(Assert.java:87)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.junit.Assert.assertTrue(Assert.java:53)
	at org.keycloak.testsuite.forms.BrowserFlowTest.testLoginWithWithNoOTPCredential(BrowserFlowTest.java:929)
...

Report flaky test

@ahus1 ahus1 force-pushed the is-31598-fix-curl branch from bcf9c1c to 54b9d4e Compare July 26, 2024 08:10
@ahus1 ahus1 marked this pull request as ready for review July 26, 2024 10:14
@ahus1 ahus1 requested review from a team as code owners July 26, 2024 10:14
mhajas
mhajas approved these changes Jul 26, 2024
View reviewed changes
Copy link
Contributor

@mhajas mhajas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ahus1

@mhajas mhajas merged commit 6c8aa65 into keycloak:main Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

4 more reviewers

@keycloak-github-bot keycloak-github-bot[bot] keycloak-github-bot[bot] left review comments

@jonkoops jonkoops jonkoops approved these changes

@miquelsi miquelsi miquelsi approved these changes

@mhajas mhajas mhajas approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ahus1 ahus1

Labels

flaky-test team/cloud-native

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CURL commands in build don't check the response code

4 participants

@ahus1 @jonkoops @miquelsi @mhajas