Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Testsuite PoC - RealmRef for Client and User #31671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pedroigor merged 4 commits into from
Aug 9, 2024
Merged

Testsuite PoC - RealmRef for Client and User #31671

pedroigor merged 4 commits into from
Aug 9, 2024

Conversation

@lhanusov
Copy link
Contributor

@lhanusov lhanusov commented Jul 26, 2024

Closes #30613

@lhanusov lhanusov marked this pull request as ready for review July 30, 2024 09:24
@lhanusov lhanusov requested a review from a team as a code owner July 30, 2024 09:24
@lhanusov lhanusov force-pushed the 30613 branch 3 times, most recently from 7b238e3 to eecb695 Compare July 30, 2024 09:57
@lhanusov lhanusov requested a review from stianst July 30, 2024 09:58
@keycloak-github-bot keycloak-github-bot bot mentioned this pull request Jul 30, 2024
Closed
vaceksimon
vaceksimon approved these changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@vaceksimon vaceksimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@keycloak-github-bot
Copy link

keycloak-github-bot bot commented Jul 30, 2024

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.forms.BruteForceTest#testRaceAttackPermanentLockout

Keycloak CI - Forms IT (firefox)

java.lang.AssertionError: Invalid count should be less than or equal 2 but was: 3
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.keycloak.testsuite.forms.BruteForceTest.raceAttack(BruteForceTest.java:820)
	at org.keycloak.testsuite.forms.BruteForceTest.testRaceAttackPermanentLockout(BruteForceTest.java:790)
...

Report flaky test

org.keycloak.testsuite.forms.BruteForceTest#testRaceAttackTemporaryLockout

Keycloak CI - Forms IT (firefox)

java.lang.AssertionError: Invalid count should be less than or equal 2 but was: 3
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.keycloak.testsuite.forms.BruteForceTest.raceAttack(BruteForceTest.java:820)
	at org.keycloak.testsuite.forms.BruteForceTest.testRaceAttackTemporaryLockout(BruteForceTest.java:773)
...

Report flaky test

keycloak-github-bot[bot]
keycloak-github-bot bot reviewed Jul 30, 2024
View reviewed changes
Copy link

@keycloak-github-bot keycloak-github-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@vaceksimon vaceksimon self-requested a review July 30, 2024 14:10
keycloak-github-bot[bot]
keycloak-github-bot bot reviewed Jul 31, 2024
View reviewed changes
Copy link

@keycloak-github-bot keycloak-github-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
Copy link

keycloak-github-bot bot commented Jul 31, 2024

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.forms.BruteForceTest#testRaceAttackPermanentLockout

Keycloak CI - Forms IT (firefox)

java.lang.AssertionError: Invalid count should be less than or equal 2 but was: 3
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.keycloak.testsuite.forms.BruteForceTest.raceAttack(BruteForceTest.java:820)
	at org.keycloak.testsuite.forms.BruteForceTest.testRaceAttackPermanentLockout(BruteForceTest.java:790)
...

Report flaky test

org.keycloak.testsuite.forms.BruteForceTest#testRaceAttackTemporaryLockout

Keycloak CI - Forms IT (firefox)

java.lang.AssertionError: Invalid count should be less than or equal 2 but was: 3
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.keycloak.testsuite.forms.BruteForceTest.raceAttack(BruteForceTest.java:820)
	at org.keycloak.testsuite.forms.BruteForceTest.testRaceAttackTemporaryLockout(BruteForceTest.java:773)
...

Report flaky test

lhanusov
lhanusov commented Jul 31, 2024
View reviewed changes
@vaceksimon vaceksimon force-pushed the 30613 branch 2 times, most recently from 9235f0f to c63b954 Compare August 1, 2024 07:31
keycloak-github-bot[bot]
keycloak-github-bot bot reviewed Aug 1, 2024
View reviewed changes
Copy link

@keycloak-github-bot keycloak-github-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
Copy link

keycloak-github-bot bot commented Aug 1, 2024

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.forms.BruteForceTest#testRaceAttackPermanentLockout

Keycloak CI - Forms IT (chrome)

java.lang.AssertionError: Invalid count should be less than or equal 2 but was: 3
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.keycloak.testsuite.forms.BruteForceTest.raceAttack(BruteForceTest.java:820)
	at org.keycloak.testsuite.forms.BruteForceTest.testRaceAttackPermanentLockout(BruteForceTest.java:790)
...

Report flaky test

@keycloak-github-bot keycloak-github-bot bot mentioned this pull request Aug 5, 2024
Closed
@keycloak-github-bot keycloak-github-bot bot mentioned this pull request Aug 5, 2024
Closed
keycloak-github-bot[bot]
keycloak-github-bot bot reviewed Aug 5, 2024
View reviewed changes
Copy link

@keycloak-github-bot keycloak-github-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
Copy link

keycloak-github-bot bot commented Aug 5, 2024

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.forms.BruteForceTest#testRaceAttackTemporaryLockout

Keycloak CI - Base IT (5)

java.lang.AssertionError: Invalid count should be less than or equal 2 but was: 3
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.keycloak.testsuite.forms.BruteForceTest.raceAttack(BruteForceTest.java:820)
	at org.keycloak.testsuite.forms.BruteForceTest.testRaceAttackTemporaryLockout(BruteForceTest.java:773)
...

Report flaky test

org.keycloak.testsuite.forms.BruteForceTest#testRaceAttackTemporaryLockout

Keycloak CI - Forms IT (chrome)

java.lang.AssertionError: Invalid count should be less than or equal 2 but was: 3
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.keycloak.testsuite.forms.BruteForceTest.raceAttack(BruteForceTest.java:820)
	at org.keycloak.testsuite.forms.BruteForceTest.testRaceAttackTemporaryLockout(BruteForceTest.java:773)
...

Report flaky test

miquelsi
miquelsi approved these changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@miquelsi miquelsi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job, thanks @vaceksimon and @lhanusov!

@vaceksimon vaceksimon requested a review from pedroigor August 8, 2024 09:20
@pedroigor pedroigor merged commit e8d2946 into keycloak:main Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pedroigor pedroigor pedroigor approved these changes

@jonkoops jonkoops Awaiting requested review from jonkoops

@stianst stianst Awaiting requested review from stianst

+3 more reviewers

@vaceksimon vaceksimon vaceksimon approved these changes

@keycloak-github-bot keycloak-github-bot[bot] keycloak-github-bot[bot] left review comments

@miquelsi miquelsi miquelsi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

flaky-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Testsuite PoC - Injection framework should support multiple instances configured differently

4 participants

@lhanusov @pedroigor @miquelsi @vaceksimon