Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@mint-lemon-eucalyptus
Copy link

Closes #31708

@mint-lemon-eucalyptus mint-lemon-eucalyptus requested a review from a team as a code owner July 29, 2024 10:49
@mint-lemon-eucalyptus mint-lemon-eucalyptus force-pushed the issue-31708 branch 2 times, most recently from 4f5c039 to 4e96578 Compare July 29, 2024 10:56
Signed-off-by: mint-lemon-eucalyptus <[email protected]>
@mhajas
Copy link
Contributor

mhajas commented Aug 12, 2024

@ahus1 Was it on purpose to prohibit using SimpleHttp with custom HttpClient here #27656?

@mint-lemon-eucalyptus
Copy link
Author

@ahus1, with the changes in #27656 it is not possible to pass a http client with own configuration. When keycloak will be used with built-in OIDC identity-providers, it works fine, because http client takes truststore from global settings. But i have a custom identity provider, which works only over mTLS and adding the additional key/certificate pair to the global truststore was not an option, for this i needed to build a separate http client. My pull-request does not break the mentioned above, it is just an extension for this particular case.

@ahus1
Copy link
Contributor

ahus1 commented Aug 18, 2024

@mint-lemon-eucalyptus - the original use case for the SimpleHttp was to provide a pre-configured common HTTP Client so you don't need to configure your own.

The methods you now ask to be public require an Apache HttpClient to be created first. Before I would consider making the methods public, I'd like to understand the added value you get from using SimpleHttp and not using the Apache HttpClient without it.

@mint-lemon-eucalyptus
Copy link
Author

@ahus1, just look at AbstractOAuth2IdentityProvider.Endpoint class. The added value will be a separate keystore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Methods of SimpleHttp are still too much protected

3 participants