Remove the attempt in brute force when the off-thread finishes #31951
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes keycloak#31881 Signed-off-by: rmartinc <[email protected]>
pedroigor
approved these changes
Aug 6, 2024
rmartinc
commented
Aug 6, 2024
| @Override | ||
| protected void commitImpl() { | ||
| // remove or wait the main thread to finish | ||
| loginAttempts.computeIfPresent(userId, (k, v) -> v.isEmpty()? null : v.substring(0, v.length() - OFF_THREAD_STARTED.length())); |
Contributor
Author
There was a problem hiding this comment.
If you prefer:
v.endsWith(OFF_THREAD_STARTED)? v.substring(0, v.length() - OFF_THREAD_STARTED.length()) : nullJust let me know. It should be the same but maybe it's more clear.
Contributor
There was a problem hiding this comment.
It might happen to not have the suffix appended to the value? If not, works for me.
Contributor
Author
There was a problem hiding this comment.
No, or it has the suffix appended (off-thread is finishing first) or it is empty (main thread finished first). I think it's the same.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #31881
The PR removes the user attempt ensuring the off-thread for brute-force has also been executed. Previously it was removed when the request finished and, as the brute force is working off-thread, there can be a race again in that last part (less probably but it can happen). With this change I could execute the test 30 times in the CI and 50 times locally without issues.