-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Add getter-methods to OAuth2GrantType.Context #31077
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add getter-methods to OAuth2GrantType.Context #31077
Conversation
fixes keycloak#31076 Signed-off-by: Pascal Knüppel <[email protected]>
be7d973 to
65273bb
Compare
|
@Captain-P-Goldfish - thank you for this PR. There is no need to rebase your PR unless a maintainer ask you for this, or a conflict appears in your PR. I don't know if you have discussed this change already with someone from the @keycloak/core-clients team. I'd assume they would be the ones to review it. |
|
No I haven't discussed it with any of the maintainers. It is just that we need an adjusted workflow and I am currently trying to add this workflow into keycloak by using its superb externsibility possiblities. But I got stuck on several points and I added a few PullRequests for each of these problems. |
|
When the changes you did, it seems that those are related to OIDC. There is an Keycloak OIDC special interest group (SIG). You can discuss your ideas there and you'll receive feedback from both OIDC experts and Keycloak maintainers. For more general enhancements, an email to the Keycloak developer mailing list helps. |
mposolda
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Captain-P-Goldfish Adding getters make sense. Thanks for this PR
closes keycloak#31076 Signed-off-by: Pascal Knüppel <[email protected]>
closes keycloak#31076 Signed-off-by: Pascal Knüppel <[email protected]>
fixes #31076
EDIT:
I haven't added a getter-method for the DPoP object to prevent a conflict with #29967