Added template overrides #31106
Merged
Added template overrides #31106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
|
fixes: keycloak#31021 Signed-off-by: Erik Jan de Wit <[email protected]>
2 tasks
Signed-off-by: Erik Jan de Wit <[email protected]>
Contributor
Author
|
@xianli123 right, made "cancel button" a link |
Contributor
thomasdarimont
suggested changes
Jul 15, 2024
Contributor
thomasdarimont
left a comment
There was a problem hiding this comment.
We should use the proper css selector for the recovery-codes-list.
themes/src/main/resources/theme/base/login/login-recovery-authn-code-config.ftl
Outdated
Show resolved
Hide resolved
themes/src/main/resources/theme/keycloak.v2/login/login-recovery-authn-code-config.ftl
Outdated
Show resolved
Hide resolved
themes/src/main/resources/theme/keycloak.v2/login/resources/css/styles.css
Outdated
Show resolved
Hide resolved
jonkoops
suggested changes
Jul 15, 2024
themes/src/main/resources/theme/base/login/login-recovery-authn-code-config.ftl
Show resolved
Hide resolved
2 tasks
* addressed PR comments Signed-off-by: Erik Jan de Wit <[email protected]>
jonkoops
approved these changes
Jul 15, 2024
thomasdarimont
approved these changes
Jul 15, 2024
edewit
added a commit
to edewit/keycloak
that referenced
this pull request
Jul 16, 2024
This reverts commit 0a5a082.
hmlnarik
pushed a commit
that referenced
this pull request
Jul 16, 2024
This reverts commit 0a5a082.
stianst
pushed a commit
to stianst/keycloak
that referenced
this pull request
Jul 25, 2024
* Added template overrides fixes: keycloak#31021 Signed-off-by: Erik Jan de Wit <[email protected]> * pr review comment Signed-off-by: Erik Jan de Wit <[email protected]> * * removed duplicated javascript and fixed formatting * addressed PR comments Signed-off-by: Erik Jan de Wit <[email protected]> --------- Signed-off-by: Erik Jan de Wit <[email protected]>
stianst
pushed a commit
to stianst/keycloak
that referenced
this pull request
Jul 25, 2024
This reverts commit 0a5a082.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #31021