Testsuite PoC - Ability to configure server run-mode within the JUnit5 framework #31109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stianst
reviewed
Jul 9, 2024
...amework/src/main/java/org/keycloak/test/framework/server/DistributionKeycloakTestServer.java
Outdated
Show resolved
Hide resolved
stianst
reviewed
Jul 9, 2024
Contributor
stianst
left a comment
There was a problem hiding this comment.
Perhaps it would be an idea to add AbstractKeycloakTestServerSupplier with all the boiler plate and one abstract method like:
public abstract KeycloakTestServer getServer()
…5 framework Signed-off-by: Lukas Hanusovsky <[email protected]>
stianst
approved these changes
Jul 9, 2024
jonkoops
approved these changes
Jul 9, 2024
Captain-P-Goldfish
pushed a commit
to Captain-P-Goldfish/keycloak
that referenced
this pull request
Jul 17, 2024
…5 framework (keycloak#31109) Signed-off-by: Lukas Hanusovsky <[email protected]>
stianst
pushed a commit
to stianst/keycloak
that referenced
this pull request
Jul 25, 2024
…5 framework (keycloak#31109) Signed-off-by: Lukas Hanusovsky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #29700