-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Testsuite PoC - Add managed user #31151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonkoops
previously approved these changes
Jul 9, 2024
...c/framework/src/main/java/org/keycloak/test/framework/server/KeycloakTestServerSupplier.java
Outdated
Show resolved
Hide resolved
b3dc6dd to
c0ce367
Compare
jonkoops
previously approved these changes
Jul 9, 2024
lhanusov
reviewed
Jul 9, 2024
test-poc/base/src/test/java/org/keycloak/test/base/ManagedResourcesTest.java
Outdated
Show resolved
Hide resolved
lhanusov
reviewed
Jul 9, 2024
test-poc/base/src/test/java/org/keycloak/test/base/ManagedResourcesTest.java
Outdated
Show resolved
Hide resolved
lhanusov
reviewed
Jul 9, 2024
test-poc/framework/src/main/java/org/keycloak/test/framework/realm/UserSupplier.java
Outdated
Show resolved
Hide resolved
c0ce367 to
c399ad3
Compare
lhanusov
approved these changes
Jul 9, 2024
Contributor
lhanusov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you 👍
jonkoops
previously approved these changes
Jul 9, 2024
Contributor
jonkoops
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catches @lhanusov, LGTM
Closes keycloak#31150 Signed-off-by: stianst <[email protected]>
c399ad3 to
3d14b28
Compare
jonkoops
approved these changes
Jul 9, 2024
Captain-P-Goldfish
pushed a commit
to Captain-P-Goldfish/keycloak
that referenced
this pull request
Jul 17, 2024
Closes keycloak#31150 Signed-off-by: stianst <[email protected]>
stianst
added a commit
to stianst/keycloak
that referenced
this pull request
Jul 25, 2024
Closes keycloak#31150 Signed-off-by: stianst <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #31150