Add @JsonIgnore to SingleUseObjectKeyModel's getExpiration()#31172
Merged
ahus1 merged 1 commit intokeycloak:mainfrom Jul 10, 2024
Merged
Add @JsonIgnore to SingleUseObjectKeyModel's getExpiration()#31172ahus1 merged 1 commit intokeycloak:mainfrom
ahus1 merged 1 commit intokeycloak:mainfrom
Conversation
Closes keycloak#31171 Signed-off-by: Johannes Knutsen <[email protected]>
Member
|
cc: @mposolda & @pedroigor: FYI as this relates to the Core teams, and touches a PR #27715 you were involved earlier. |
ahus1
approved these changes
Jul 10, 2024
Member
ahus1
left a comment
There was a problem hiding this comment.
Thank you for this PR, this field shouldn't have ended up there :-(
I'm marking it as a regression as this enlarges the tokens unnecessarily, which might be a problem for some users that go to the limits with their token lenghts.
Member
|
@knutz3n - could you please create the same PR against the release branch |
Contributor
Author
|
Thanks for the quick response on this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #31171