Testsuite PoC - distribution server run mode. #31186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miquelsi
approved these changes
Jul 11, 2024
jonkoops
reviewed
Jul 11, 2024
...amework/src/main/java/org/keycloak/test/framework/server/DistributionKeycloakTestServer.java
Outdated
Show resolved
Hide resolved
...amework/src/main/java/org/keycloak/test/framework/server/DistributionKeycloakTestServer.java
Outdated
Show resolved
Hide resolved
stianst
previously approved these changes
Jul 11, 2024
stianst
previously approved these changes
Jul 11, 2024
Signed-off-by: Lukas Hanusovsky <[email protected]>
pedroigor
approved these changes
Jul 11, 2024
| keycloak.setEnvVar("KC_BOOTSTRAP_ADMIN_PASSWORD", serverConfig.adminUserPassword().get()); | ||
|
|
||
| List<String> rawOptions = new LinkedList<>(); | ||
| rawOptions.add("start-dev"); |
Contributor
There was a problem hiding this comment.
Do we want to add options from org.keycloak.test.framework.server.KeycloakTestServerConfig#options now?
Contributor
Author
There was a problem hiding this comment.
@pedroigor It is copied from the EmbeddedServer setup, so not necessary to have it right now, but will be used in the future.
jonkoops
approved these changes
Jul 12, 2024
stianst
approved these changes
Jul 15, 2024
stianst
pushed a commit
to stianst/keycloak
that referenced
this pull request
Jul 25, 2024
Signed-off-by: Lukas Hanusovsky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #29702