fix: fail to start if the admin user can't be added #31207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d79103f to
f198cd7
Compare
Contributor
Author
|
@mabartos @vmuzikar @Pepo48 it was missed in the earlier pr that the bootstrap admin property mappers needed to be added to be used directly by the cli. Once added however they still showed up in the help system, even though they were marked as hidden. This was a side effect of the disabled mapper logic, so the help visibility check was simplified. If need be that could be separated to a different pr or backported individually. |
also allowing the bootstrap options to be used by the cli, which requires hidden options to stay hidden and a minor refactoring for clarity closes: keycloak#31160 Signed-off-by: Steve Hawkins <[email protected]>
Pepo48
approved these changes
Jul 16, 2024
Contributor
Author
2 tasks
stianst
pushed a commit
to stianst/keycloak
that referenced
this pull request
Jul 25, 2024
also allowing the bootstrap options to be used by the cli, which requires hidden options to stay hidden and a minor refactoring for clarity closes: keycloak#31160 Signed-off-by: Steve Hawkins <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also allowing the bootstrap options to be used by the cli
and minor refactoring for clarity
closes: #31160 #31340