Offline tokens created in Keycloak 14 or earlier will not work on Key… #31258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cloak 25 closes keycloak#31224 Signed-off-by: mposolda <[email protected]>
jonkoops
approved these changes
Jul 14, 2024
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…cloak 25
closes #31224
Some additional notes to this PR:
session_state, but notsidsidadded in addition tosession_state. Related commit: 8c1ea60bsession_statewas removed and onlysidwas kept. Related commit: b4f791b6So migration of offline tokens is broken from Keycloak versions 14 or earlier to Keycloak 25 versions. This means that fix requires backport to Keycloak 25.0.X as well.
This issue is not caught by the
MigrationTest, which tests migration of offline tokens, but just from some recent Keycloak version. In this PR, I've addedOfflineTokenMigrationTestto simulate migration of old offline tokens to the latest Keycloak.