Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Normalize built-in flow descriptions to start with an uppercase letter#31277

Merged
jonkoops merged 1 commit intokeycloak:mainfrom
stfnzl:uppercase-default-auth-description
Jul 16, 2024
Merged

Normalize built-in flow descriptions to start with an uppercase letter#31277
jonkoops merged 1 commit intokeycloak:mainfrom
stfnzl:uppercase-default-auth-description

Conversation

@stfnzl
Copy link
Contributor

@stfnzl stfnzl commented Jul 14, 2024

This to address the inconsistency between the description for the "browser" and "registration", and the other flows.

Fixes #31291

Since this applies to only new instances of Keycloak, should the description be migrated for already initialized instances as well?

image

@stfnzl stfnzl requested a review from a team as a code owner July 14, 2024 18:57
@stfnzl stfnzl force-pushed the uppercase-default-auth-description branch from 87431ac to c72ad9b Compare July 14, 2024 18:59
@jonkoops
Copy link
Contributor

@stfnzl could you log an issue and link it to this PR? We need this in order to keep track of changes.

@stfnzl stfnzl force-pushed the uppercase-default-auth-description branch from df408bb to 8dc0de8 Compare July 15, 2024 11:26
@stfnzl stfnzl requested review from a team as code owners July 15, 2024 11:26
@stfnzl stfnzl force-pushed the uppercase-default-auth-description branch from 8dc0de8 to d3467c7 Compare July 15, 2024 11:30
@stfnzl stfnzl force-pushed the uppercase-default-auth-description branch from d3467c7 to f2aa37e Compare July 15, 2024 21:42
@mposolda mposolda self-assigned this Jul 16, 2024
Copy link
Contributor

@mposolda mposolda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stfnzl Thanks for the PR. Should be OK to merge IMO if tests are passing.

Copy link
Contributor

@jonkoops jonkoops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonkoops jonkoops merged commit 6d67c1f into keycloak:main Jul 16, 2024
@jonkoops
Copy link
Contributor

Thanks for your contribution @stfnzl!

@stfnzl stfnzl deleted the uppercase-default-auth-description branch July 16, 2024 12:03
stianst pushed a commit to stianst/keycloak that referenced this pull request Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incosistent casing of built-in flow descriptions

3 participants