Removing adapter-feature-pack from the distribution #31344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes keycloak#31343 Signed-off-by: mposolda <[email protected]>
pedroigor
approved these changes
Jul 16, 2024
Contributor
|
Elytron OIDC is a built-in module so yeah we don't need to install it. See https://github.com/keycloak/keycloak-quickstarts/tree/latest/jakarta/servlet-authz-client. |
jonkoops
approved these changes
Jul 16, 2024
pskopek
approved these changes
Jul 17, 2024
Contributor
pskopek
left a comment
There was a problem hiding this comment.
LGTM! No need to keep OIDC adapter as Wildfly has its own thing.
Contributor
Author
|
@pedroigor @jonkoops @pskopek Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #31343
@pskopek @pedroigor It looks that adapter-feature-pack is not needed anymore for anything as Elytron has it's own OIDC adapter, which is supposed to be used by Wildfly. Or am I missing something?