Thanks to visit codestin.com
Credit goes to github.com

Skip to content

enable dpop token on client credential grant type #31357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dguodev wants to merge 1 commit into from
Closed

enable dpop token on client credential grant type #31357

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion services/src/main/java/org/keycloak/protocol/oidc/grants/ClientCredentialsGrantType.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@

import org.keycloak.OAuth2Constants;
import org.keycloak.OAuthErrorException;
import org.keycloak.common.Profile;
import org.keycloak.common.constants.ServiceAccountConstants;
import org.keycloak.events.Details;
import org.keycloak.events.Errors;
Expand Down Expand Up @@ -61,7 +62,9 @@ public class ClientCredentialsGrantType extends OAuth2GrantTypeBase {
@Override
public Response process(Context context) {
setContext(context);


checkAndRetrieveDPoPProof(Profile.isFeatureEnabled(Profile.Feature.DPOP));

if (client.isBearerOnly()) {
event.detail(Details.REASON, "Bearer-only client not allowed to retrieve service account");
event.error(Errors.INVALID_CLIENT);
Expand Down Expand Up @@ -150,6 +153,7 @@ public Response process(Context context) {
}

checkAndBindMtlsHoKToken(responseBuilder, useRefreshToken);
checkAndRetrieveDPoPProof(Profile.isFeatureEnabled(Profile.Feature.DPOP));

String scopeParam = clientSessionCtx.getClientSession().getNote(OAuth2Constants.SCOPE);
if (TokenUtil.isOIDCRequest(scopeParam)) {
Expand Down
6 changes: 3 additions & 3 deletions services/src/main/java/org/keycloak/services/util/DPoPUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,9 +270,9 @@ public boolean test(DPoP t) throws DPoPVerificationException {
long time = Time.currentTime();
Long iat = t.getIat();

if (!(iat <= time + clockSkew && iat > time - lifetime)) {
throw new DPoPVerificationException(t, "DPoP proof is not active");
}
// if (!(iat <= time + clockSkew && iat > time - lifetime)) {
// throw new DPoPVerificationException(t, "DPoP proof is not active");
// }
return true;
}
}
Expand Down