Wait for the brute force off-thread processing in AbstractAdvancedBrokerTest#31385
Merged
mposolda merged 1 commit intokeycloak:mainfrom Jul 18, 2024
Merged
Wait for the brute force off-thread processing in AbstractAdvancedBrokerTest#31385mposolda merged 1 commit intokeycloak:mainfrom
mposolda merged 1 commit intokeycloak:mainfrom
Conversation
…kerTest Closes keycloak#30188 Closes keycloak#30641 Signed-off-by: rmartinc <[email protected]>
mposolda
approved these changes
Jul 18, 2024
Member
|
@rmartinc - may I ask you to backport this to KC24 + KC25 to have stable tests in those branches as well? Possibly KC22 would be too much, I leave that up to you. |
This was referenced Jul 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #30188
Closes #30641
The brute force works off-thread so the disable can delay a bit. Usually it's fast and it's executed before the next login but it seems that sometimes the race can be won by the next login. Just using the the event to be sure the brute force processing was executed. A new method waits for the event to come up to N seconds.
I tested 60 times here https://github.com/rmartinc/keycloak/actions/runs/9973832926. I executed the two tests (KcSamlBrokerTest and KcOidcBrokerTest) in a for loop 30 times, and I repeated the CI run. I think 60 times without issues is enough.